Add terminal block hash and number to Ropsten genesis file #4026
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Fabio Di Fabio <fabio.difabio@consensys.net>
fab-10
force-pushed
the
ropsten-terminal-block-hash-number-genesis
branch
from
9cc615b
to
0e7a7d7
Compare
Signed-off-by: Fabio Di Fabio <fabio.difabio@consensys.net>
Signed-off-by: Fabio Di Fabio <fabio.difabio@consensys.net>
shemnon
reviewed
Jun 28, 2022
| validators.add( | ||
| new DaoForkPeerValidator(protocolSchedule, metricsSystem, daoBlock.getAsLong())); | ||
| } | ||
| configOptionsSupplier |
There was a problem hiding this comment.
This is less readable than an if block.
There was a problem hiding this comment.
I usually find the lambda version more effective to describe what to do in case of something is present, and less error prone, but I can easily read both versions, so I will revert.
|
|
||
| for (final Map.Entry<Long, Hash> requiredBlock : requiredBlocks.entrySet()) { | ||
| validators.add( | ||
| new RequiredBlocksPeerValidator( | ||
| protocolSchedule, metricsSystem, requiredBlock.getKey(), requiredBlock.getValue())); | ||
| } | ||
|
|
||
| configOptionsSupplier |
There was a problem hiding this comment.
This is not as readable as a couple of if blocks. Two if blocks would make it obvious we are adding a config if two config items are persent. get().get().filter(...).ifPresent(...) is much too verbose, especially when one of the ifPresent paths is nested.
Signed-off-by: Fabio Di Fabio <fabio.difabio@consensys.net>
shemnon
approved these changes
Jun 29, 2022
macfarla
approved these changes
Jun 30, 2022
matkt
added a commit
to matkt/besu
that referenced
this pull request
Jul 7, 2022
…yperledger#4026)" This reverts commit 27fc468. Signed-off-by: Karim TAAM <karim.t2am@gmail.com>
fab-10
added a commit
to fab-10/besu
that referenced
this pull request
Jul 13, 2022
…yperledger#4026)" This reverts commit 27fc468.
fab-10
added a commit
to fab-10/besu
that referenced
this pull request
Jul 13, 2022
…yperledger#4026)" This reverts commit 27fc468. Signed-off-by: Fabio Di Fabio <fabio.difabio@consensys.net>
fab-10
added a commit
that referenced
this pull request
Jul 13, 2022
eum602
pushed a commit
to lacchain/besu
that referenced
this pull request
Nov 3, 2023
…er#4026) Signed-off-by: Fabio Di Fabio <fabio.difabio@consensys.net> * If terminal block is present in the genesis, then peers must have it Signed-off-by: Fabio Di Fabio <fabio.difabio@consensys.net> * Update unit test Signed-off-by: Fabio Di Fabio <fabio.difabio@consensys.net> * address review comments Signed-off-by: Fabio Di Fabio <fabio.difabio@consensys.net>
eum602
pushed a commit
to lacchain/besu
that referenced
this pull request
Nov 3, 2023
…yperledger#4026)" (hyperledger#4093) This reverts commit 27fc468. Signed-off-by: Fabio Di Fabio <fabio.difabio@consensys.net>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Signed-off-by: Fabio Di Fabio fabio.difabio@consensys.net
PR description
Add terminal block hash and number to Ropsten genesis file, and also require that peers on Ropsten must have that block
Fixed Issue(s)
Documentation
doc-change-requiredlabel to this PR ifupdates are required.
Changelog