candidate fix for missing parent worldstate #4094
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Karim TAAM <karim.t2am@gmail.com>
shemnon
reviewed
Jul 13, 2022
| worldStateBlockHash = blockHeader.getHash(); | ||
| worldStateRootHash = newWorldStateRootHash; | ||
| } finally { | ||
| stateUpdater.commit(); |
There was a problem hiding this comment.
Should this be up at line 47/50 instead? Do we want to commit the state updater if persistTrieLog throws an error?
There was a problem hiding this comment.
Yes you right. Good catch
Signed-off-by: Karim TAAM <karim.t2am@gmail.com>
Signed-off-by: Karim TAAM <karim.t2am@gmail.com>
Signed-off-by: Karim TAAM <karim.t2am@gmail.com>
Signed-off-by: Karim TAAM <karim.t2am@gmail.com>
|
🚢 |
jflo
approved these changes
Jul 18, 2022
eum602
pushed a commit
to lacchain/besu
that referenced
this pull request
Nov 3, 2023
* candidate fix for missing parent worldstate * add rollback if failure * fix persist trie log issue * add trielog manager * fix inmemory issue for bonsai Signed-off-by: Karim TAAM <karim.t2am@gmail.com> Co-authored-by: garyschulte <garyschulte@gmail.com> Co-authored-by: Justin Florentine <justin+github@florentine.us>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Signed-off-by: Karim TAAM karim.t2am@gmail.com
PR description
when we remember block after the merge we must persist the trielog. because if we lose the trielog in the memory (ex restart besu) we can end up in a case where the block is saved but not the trielog. this can prevent the rollback or the rollforward to work because besu will consider that it can do it as the block is present but it will failed because trielog is missing.
may be one of the reasons for the problem found on a ropsten test node
A possible edgecase description :
now we have
if we restart before the reorg trielog 6 is missing
this PR also fix an issue related to an invalid implementation of BonsaiInmemoryWorldstate
Fixed Issue(s)
#4084
Documentation
doc-change-requiredlabel to this PR ifupdates are required.
Changelog