WIP EthPeers - remove if disconnected #4100
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Sally MacFarlane <sally.macfarlane@consensys.net>
|
As suspected, this has caused an issue with callbacks |
|
However, it does seem to have eliminated the "keeping disconnected peers" scenario |
macfarla
commented
Jul 20, 2022
| // if duplicate inbound and outbound connections are established at the same time | ||
| if (peer.isDisconnected()) { | ||
| connections.remove(peerConnection); | ||
| } |
There was a problem hiding this comment.
this is the core change here. the rest is logging.
There was a problem hiding this comment.
This could be a quick fix, but it would be better to sort out the underlying problem wrt how connect / disconnect events are being dispatched. The comment here isn't really accurate, its actually a bug if these events aren't propagated correctly to EthPeers and it doesn't necessarily have to do with duplicate connections.
On the theory that we're dispatching the disconnect event before the connect event, I haven't looked into this too deeply, but I would probably look at moving connection dispatch logic into PeerConnectionEvents. From there, you could do something like keep a connectedFuture, and when dispatchDisconnect is invoked, you could chain that logic to connectedFuture so that we're ensuring connect and disconnect events are dispatched in order.
jflo
approved these changes
Jul 20, 2022
| @@ -312,9 +313,15 @@ public void processMessage(final Capability cap, final Message message) { | |||
|
|
|||
| @Override | |||
| public void handleNewConnection(final PeerConnection connection) { | |||
| LOG.trace( | |||
| "handleNewConnection {} 6 disconnected? {}", | |||
There was a problem hiding this comment.
Did you intend to approve a draft PR with test failures?
This is caused by the extra logic in the toString that was added here. The |
|
Closing this one as it does not seem like a viable approach |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Testing a theory with EthPeer disconnects. From looking at logs, there's a spot in the code where it seems that duplicate connection is detected and disconnected, while the EthPeer is being created and added, so that by the time it is added, it's already disconnected.
This may not be the most elegant solution but I'm running it up and it seems to work but does create an issue with the callbacks - but I think the callback issue might be there anyway.
Documentation
doc-change-requiredlabel to this PR ifupdates are required.
Changelog