lower bound peer limit #4200

macfarla · 2022-08-01T02:25:10Z

Added (experimental) CLI option for a lower bound for p2p peers. Similar to Teku's https://docs.teku.consensys.net/en/latest/Reference/CLI/CLI-Syntax/#p2p-peer-lower-bound

So we actively try to find more peers up to --Xp2p-peer-lower-bound, but still allow incoming connections until we hit --p2p-peer-upper-bound AKA --max-peers, only then we refuse incoming connections.

Note currently this PR changes the default for max-peers - happy to change this back once the plumbing for deploying canary nodes supports the "lower-bound" param
Timer refresh for the peer table tableRefreshIntervalMs is 30 minutes

Documentation

I thought about documentation and added the doc-change-required label to this PR if
updates are required.

Changelog

I thought about the changelog and included a changelog update if required.

…ledger#4170) Signed-off-by: Roman Vaseev <4833306+Filter94@users.noreply.github.com> Co-authored-by: Justin Florentine <justin+github@florentine.us> Signed-off-by: Sally MacFarlane <sally.macfarlane@consensys.net>

Signed-off-by: Sally MacFarlane <sally.macfarlane@consensys.net>

…imit

Signed-off-by: Sally MacFarlane <sally.macfarlane@consensys.net>

garyschulte · 2022-08-02T03:58:36Z

besu/src/test/java/org/hyperledger/besu/cli/BesuCommandTest.java

@@ -228,7 +228,7 @@ public void callingVersionDisplayBesuInfoVersion() {
  public void callingBesuCommandWithoutOptionsMustSyncWithDefaultValues() throws Exception {
    parseCommand();

-    final int maxPeers = 25;
+    final int maxPeers = 100;


garyschulte

Looks good on first run through, some minor nitpicks

besu/src/main/java/org/hyperledger/besu/RunnerBuilder.java

ethereum/eth/src/main/java/org/hyperledger/besu/ethereum/eth/manager/EthProtocolManager.java

besu/src/main/java/org/hyperledger/besu/cli/DefaultCommandValues.java

ethereum/p2p/src/main/java/org/hyperledger/besu/ethereum/p2p/config/RlpxConfiguration.java

Signed-off-by: Sally MacFarlane <sally.macfarlane@consensys.net>

fab-10

LGTM, a couple of log level suggestions.
The main point is to verify if and how the increased number of peers impacts the perfomance on small machines.

Fun fact:
playing with the configuration of remote-connections-max-percentage, is possible to launch Besu in a way that it never reaches the max peers upped limit, for example is lower limit is 50, upper limit is 100, and remote-connections-max-percentage is 10, the max number of connected peers should be 60

fab-10 · 2022-08-03T13:52:16Z

besu/src/main/java/org/hyperledger/besu/cli/DefaultCommandValues.java

+  int DEFAULT_MAX_PEERS = 100;
+  int DEFAULT_P2P_PEER_LOWER_BOUND = 64;


since this change max peers to 4 times the actual max, it could impact memory, cpu and lock contention, especially on resource constrained nodes

yes I want to collect some metrics on this. maybe 25/50 would be a more sensible default.

I'd be very cautious about raising the peer limit. From what I've seen besu works really well when it has 25 peers, it just tends to struggling to fill it's peer quota at times which is when it then struggles. Experimenting with different values by overriding them in config is probably better than changing the defaults in code before we've checked what impact it will have.

Indeed. I've changed the defaults to min = max = 25 which is equivalent to current behavior.

besu/src/main/java/org/hyperledger/besu/cli/BesuCommand.java

ethereum/eth/src/main/java/org/hyperledger/besu/ethereum/eth/manager/EthProtocolManager.java

ethereum/p2p/src/main/java/org/hyperledger/besu/ethereum/p2p/network/DefaultP2PNetwork.java

ethereum/p2p/src/main/java/org/hyperledger/besu/ethereum/p2p/rlpx/RlpxAgent.java

Signed-off-by: Sally MacFarlane <sally.macfarlane@consensys.net>

…imit

…get-peer-limit

Signed-off-by: Sally MacFarlane <sally.macfarlane@consensys.net>

…imit 3.138.85.163:

…get-peer-limit

macfarla · 2022-08-09T04:13:06Z

Nodes running on mainnet with min=25 max=35 and two control nodes (22.7.0) with max=25 and max=35. All nodes get to min/max number of peers within ~17 minutes and peer numbers remain stable

macfarla · 2022-08-09T04:14:25Z

Nodes running on goerli with min=max=25
nodes get to max peers within 1hr and remain stable

macfarla · 2022-08-09T04:15:24Z

nodes running SNAP sync on goerli - peering behavior much more variable.

* introducing a lower bound on number of peers * added lower bound CLI option Signed-off-by: Sally MacFarlane <sally.macfarlane@consensys.net> Signed-off-by: Roman Vaseev <4833306+Filter94@users.noreply.github.com> Co-authored-by: Roman Vaseev <4833306+Filter94@users.noreply.github.com> Co-authored-by: Justin Florentine <justin+github@florentine.us>

Filter94 and others added 11 commits July 27, 2022 10:18

first draft of introducing a lower bound on number of peers

9854bb3

Signed-off-by: Sally MacFarlane <sally.macfarlane@consensys.net>

added lower bound CLI option

7b11607

Signed-off-by: Sally MacFarlane <sally.macfarlane@consensys.net>

change default values back to current defaults

59a7fea

Signed-off-by: Sally MacFarlane <sally.macfarlane@consensys.net>

Merge branch 'main' of github.com:hyperledger/besu into target-peer-l…

a94a19f

…imit

hidden CLI option

3c1003f

Signed-off-by: Sally MacFarlane <sally.macfarlane@consensys.net>

formatting

40bd6ff

Signed-off-by: Sally MacFarlane <sally.macfarlane@consensys.net>

add test

8a1da6e

Signed-off-by: Sally MacFarlane <sally.macfarlane@consensys.net>

test

e426552

Signed-off-by: Sally MacFarlane <sally.macfarlane@consensys.net>

added rlpx test

9ce3374

Signed-off-by: Sally MacFarlane <sally.macfarlane@consensys.net>

changelog

2fa135c

Signed-off-by: Sally MacFarlane <sally.macfarlane@consensys.net>

macfarla added the doc-change-required Indicates an issue or PR that requires doc to be updated label Aug 1, 2022

macfarla added 2 commits August 1, 2022 14:48

changed defaults

64b97ed

Signed-off-by: Sally MacFarlane <sally.macfarlane@consensys.net>

changed defaults

fa6e752

Signed-off-by: Sally MacFarlane <sally.macfarlane@consensys.net>

iamhsk added the TeamRevenant GH issues worked on by Revenant Team label Aug 1, 2022

This was referenced Aug 1, 2022

Investigate how Teku peer constraints are configured #4110

Closed

Implement mechanism that encourages new node participation in stable networks #4054

Closed

macfarla added mainnet peering labels Aug 1, 2022

log

f95996f

Signed-off-by: Sally MacFarlane <sally.macfarlane@consensys.net>

garyschulte reviewed Aug 2, 2022

View reviewed changes

macfarla added 5 commits August 3, 2022 11:56

merge and add test

764fb35

Signed-off-by: Sally MacFarlane <sally.macfarlane@consensys.net>

add validateOptions and some tests

0daf9b3

Signed-off-by: Sally MacFarlane <sally.macfarlane@consensys.net>

formatting

85b4b43

Signed-off-by: Sally MacFarlane <sally.macfarlane@consensys.net>

more tests; set min = max if in doubt

a6e0bc7

Signed-off-by: Sally MacFarlane <sally.macfarlane@consensys.net>

Merge branch 'main' into target-peer-limit

fc41df2

fab-10 reviewed Aug 3, 2022

View reviewed changes

macfarla added 2 commits August 4, 2022 12:26

merge

efc7b26

Signed-off-by: Sally MacFarlane <sally.macfarlane@consensys.net>

logging

73107bc

Signed-off-by: Sally MacFarlane <sally.macfarlane@consensys.net>

macfarla added 3 commits August 4, 2022 13:06

Merge branch 'main' of github.com:hyperledger/besu into target-peer-l…

892d596

…imit

Merge branch 'target-peer-limit' of github.com:macfarla/besu into tar…

cd868af

…get-peer-limit

defaults minPeers/maxPeers 25/50

20d1880

Signed-off-by: Sally MacFarlane <sally.macfarlane@consensys.net>

fab-10 approved these changes Aug 4, 2022

View reviewed changes

macfarla added 7 commits August 5, 2022 09:44

defaults minPeers/maxPeers 25/30

104ac95

Signed-off-by: Sally MacFarlane <sally.macfarlane@consensys.net>

Merge branch 'main' into target-peer-limit

2d4e5ee

changed defaults to 25/25

ca216c1

Signed-off-by: Sally MacFarlane <sally.macfarlane@consensys.net>

Merge branch 'main' of github.com:hyperledger/besu into target-peer-l…

2747c9c

…imit 3.138.85.163:

Merge branch 'target-peer-limit' of github.com:macfarla/besu into tar…

effec82

…get-peer-limit

Merge branch 'main' into target-peer-limit

de5eaab

Merge branch 'main' into target-peer-limit

c110861

macfarla merged commit 37e0e04 into hyperledger:main Aug 9, 2022

bgravenorst mentioned this pull request Aug 10, 2022

Lower bound peer limit hyperledger/besu-docs#1123

Closed

bgravenorst removed the doc-change-required Indicates an issue or PR that requires doc to be updated label Aug 10, 2022

macfarla deleted the target-peer-limit branch August 22, 2022 23:24

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

lower bound peer limit #4200

lower bound peer limit #4200

macfarla commented Aug 1, 2022 •

edited

garyschulte Aug 2, 2022 •

edited

garyschulte left a comment

fab-10 left a comment

fab-10 Aug 3, 2022

macfarla Aug 4, 2022

ajsutton Aug 4, 2022

macfarla Aug 5, 2022

macfarla commented Aug 9, 2022

macfarla commented Aug 9, 2022

macfarla commented Aug 9, 2022

		int DEFAULT_MAX_PEERS = 100;
		int DEFAULT_P2P_PEER_LOWER_BOUND = 64;

lower bound peer limit #4200

lower bound peer limit #4200

Conversation

macfarla commented Aug 1, 2022 • edited

Documentation

Changelog

garyschulte Aug 2, 2022 • edited

Choose a reason for hiding this comment

garyschulte left a comment

Choose a reason for hiding this comment

fab-10 left a comment

Choose a reason for hiding this comment

fab-10 Aug 3, 2022

Choose a reason for hiding this comment

macfarla Aug 4, 2022

Choose a reason for hiding this comment

ajsutton Aug 4, 2022

Choose a reason for hiding this comment

macfarla Aug 5, 2022

Choose a reason for hiding this comment

macfarla commented Aug 9, 2022

macfarla commented Aug 9, 2022

macfarla commented Aug 9, 2022

macfarla commented Aug 1, 2022 •

edited

garyschulte Aug 2, 2022 •

edited