Filter out disconnected peers when fetching available peers #4269
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
garyschulte
reviewed
Aug 17, 2022
| return streamAllPeers().filter(EthPeer::readyForRequests); | ||
| return streamAllPeers() | ||
| .filter(EthPeer::readyForRequests) | ||
| .filter(peer -> !peer.isDisconnected()); |
There was a problem hiding this comment.
seems sensible enough. This would be additional protection from a race between besu disconnecting a peer and subsequently responding to that disconnect?
There was a problem hiding this comment.
No sure I got your question, but this part is not affecting the way we process incoming messages
Signed-off-by: Fabio Di Fabio <fabio.difabio@consensys.net>
… for requests Signed-off-by: Fabio Di Fabio <fabio.difabio@consensys.net>
Signed-off-by: Fabio Di Fabio <fabio.difabio@consensys.net>
Signed-off-by: Fabio Di Fabio <fabio.difabio@consensys.net>
fab-10
force-pushed
the
available-peer-is-connected
branch
from
d2b07b9
to
308abaa
Compare
Signed-off-by: Fabio Di Fabio <fabio.difabio@consensys.net>
Signed-off-by: Fabio Di Fabio <fabio.difabio@consensys.net>
Signed-off-by: Fabio Di Fabio <fabio.difabio@consensys.net>
macfarla
approved these changes
Aug 23, 2022
| return streamAllPeers().filter(EthPeer::readyForRequests); | ||
| return streamAllPeers() | ||
| .filter(EthPeer::readyForRequests) | ||
| .filter(peer -> !peer.isDisconnected()); |
garyschulte
pushed a commit
to garyschulte/besu
that referenced
this pull request
Sep 7, 2022
…ger#4269) * Filter out disconnected peers when fetching available peers Signed-off-by: Fabio Di Fabio <fabio.difabio@consensys.net>
garyschulte
pushed a commit
to garyschulte/besu
that referenced
this pull request
Sep 7, 2022
…ger#4269) * Filter out disconnected peers when fetching available peers Signed-off-by: Fabio Di Fabio <fabio.difabio@consensys.net>
garyschulte
pushed a commit
to garyschulte/besu
that referenced
this pull request
Sep 7, 2022
…ger#4269) * Filter out disconnected peers when fetching available peers Signed-off-by: Fabio Di Fabio <fabio.difabio@consensys.net> Signed-off-by: garyschulte <garyschulte@gmail.com>
eum602
pushed a commit
to lacchain/besu
that referenced
this pull request
Nov 3, 2023
…ger#4269) * Filter out disconnected peers when fetching available peers Signed-off-by: Fabio Di Fabio <fabio.difabio@consensys.net>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Signed-off-by: Fabio Di Fabio fabio.difabio@consensys.net
PR description
Currently a peer that is marked as disconnected can be returned when asking
EthPeersfor available peers, but returning a disconnected peer is not useful and potentially a cause of problems since all tasks will fail on it.Not sure how much this affect peer selection in the real world, but in unit tests it happens to choose a disconnected peer for request.
In any case it seems reasonable to add this check, and we can evaluate if we also need to require that a peer is fully validated, before returning it as available
Fixed Issue(s)
Documentation
doc-change-requiredlabel to this PR ifupdates are required.
Changelog