Always shutdown the mining executor on exit #4353
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
fab-10
force-pushed
the
shutdown-powminer
branch
from
a0fe37e
to
6a334d1
Compare
fab-10
changed the title
Signed-off-by: Fabio Di Fabio <fabio.difabio@consensys.net>
fab-10
force-pushed
the
shutdown-powminer
branch
from
6a334d1
to
c9782c2
Compare
fab-10
changed the title
jflo
approved these changes
Sep 7, 2022
garyschulte
pushed a commit
to garyschulte/besu
that referenced
this pull request
Sep 7, 2022
Signed-off-by: Fabio Di Fabio <fabio.difabio@consensys.net>
garyschulte
pushed a commit
to garyschulte/besu
that referenced
this pull request
Sep 7, 2022
Signed-off-by: Fabio Di Fabio <fabio.difabio@consensys.net>
garyschulte
pushed a commit
to garyschulte/besu
that referenced
this pull request
Sep 7, 2022
Signed-off-by: Fabio Di Fabio <fabio.difabio@consensys.net> Signed-off-by: garyschulte <garyschulte@gmail.com>
eum602
pushed a commit
to lacchain/besu
that referenced
this pull request
Nov 3, 2023
Signed-off-by: Fabio Di Fabio <fabio.difabio@consensys.net>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Signed-off-by: Fabio Di Fabio fabio.difabio@consensys.net
PR description
There is an issue that prevents the PoWMiner to stop cleanly, with the effect of taking 30 seconds before the timeout expires and Besu can stop.
Basically the miner executor was only shutdown when running, but not when it was idle, this PR always shutdown the executor when the mining is stopped
Fixed Issue(s)
fixes #4313
Documentation
doc-change-requiredlabel to this PR ifupdates are required.
Changelog