Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove 'publicKey' and 'raw' from Transaction RPC API response. #4575

Merged

Conversation

mark-terry
Copy link
Contributor

Signed-off-by: mark-terry mark.terry@consensys.net

PR description

Removed extra fields 'publicKey' and 'raw' from the Transaction object returned by the RPC APIs.

Fixed Issue(s)

Fixes #4503

Documentation

  • I thought about documentation and added the doc-change-required label to this PR if
    updates are required.

Changelog

Signed-off-by: mark-terry <mark.terry@consensys.net>
@mark-terry mark-terry added doc-change-required Indicates an issue or PR that requires doc to be updated TeamRevenant GH issues worked on by Revenant Team RPC labels Oct 30, 2022
@mark-terry mark-terry self-assigned this Oct 30, 2022
mark-terry and others added 3 commits October 30, 2022 23:25
Signed-off-by: mark-terry <mark.terry@consensys.net>
Signed-off-by: mark-terry <mark.terry@consensys.net>
@mark-terry mark-terry removed the TeamRevenant GH issues worked on by Revenant Team label Nov 2, 2022
Copy link
Contributor

@daniellehrner daniellehrner left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@shemnon
Copy link
Contributor

shemnon commented Nov 4, 2022

Keep in mind that the GraphQL schema requires raw for blocks and transactions (but not publicKey). No impact here but also no need to go to other APIs.

mark-terry and others added 3 commits November 7, 2022 20:57
Signed-off-by: mark-terry <mark.terry@consensys.net>
This reverts commit 1586431.
Signed-off-by: mark-terry <36909937+mark-terry@users.noreply.github.com>
@mark-terry mark-terry merged commit 5f9c68a into hyperledger:main Nov 7, 2022
@mark-terry mark-terry deleted the transaction_remove_extra_fields branch November 7, 2022 11:52
@alexandratran alexandratran removed the doc-change-required Indicates an issue or PR that requires doc to be updated label Nov 8, 2022
macfarla pushed a commit to jflo/besu that referenced this pull request Jan 10, 2023
…rledger#4575)

* Removed 'publicKey' and 'raw' from Transaction RPC API response.

Signed-off-by: mark-terry <mark.terry@consensys.net>
Signed-off-by: Sally MacFarlane <macfarla.github@gmail.com>
eum602 pushed a commit to lacchain/besu that referenced this pull request Nov 3, 2023
…rledger#4575)

* Removed 'publicKey' and 'raw' from Transaction RPC API response.

Signed-off-by: mark-terry <mark.terry@consensys.net>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Should publicKey and raw fields be in eth_getBlockByNumber result
5 participants