Withdrawals and timestamp #4758
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jframe
force-pushed
the
withdrawals_and_timestamp
branch
from
4e79918
to
d35f3a5
Compare
![github-advanced-security[bot]](https://avatars.githubusercontent.com/in/57789?s=60&v=4){kind=small}
| @JsonProperty("prevRandao") final String prevRandao, | ||
| @JsonProperty("suggestedFeeRecipient") final String suggestedFeeRecipient, | ||
| @JsonProperty("withdrawals") final List<WithdrawalParameter> withdrawals) { | ||
| this.timestamp = Long.decode(timestamp); |
Check notice
Code scanning / CodeQL
Missing catch of NumberFormatException
ethereum/core/src/main/java/org/hyperledger/besu/ethereum/mainnet/TimestampScheduleBuilder.java
Fixed
Show fixed
Hide fixed
jframe
force-pushed
the
withdrawals_and_timestamp
branch
from
ec5358f
to
3c63f8d
Compare
Signed-off-by: Jiri Peinlich <jiri.peinlich@gmail.com>
Signed-off-by: Jiri Peinlich <jiri.peinlich@gmail.com>
Signed-off-by: Jiri Peinlich <jiri.peinlich@gmail.com>
Signed-off-by: Jiri Peinlich <jiri.peinlich@gmail.com>
Signed-off-by: Simon Dudley <simon.dudley@consensys.net> Signed-off-by: Simon Dudley <simon.dudley@consensys.net>
Signed-off-by: Simon Dudley <simon.dudley@consensys.net>
Signed-off-by: Simon Dudley <simon.dudley@consensys.net>
Signed-off-by: Simon Dudley <simon.dudley@consensys.net>
Signed-off-by: Jiri Peinlich <jiri.peinlich@gmail.com>
Signed-off-by: Simon Dudley <simon.dudley@consensys.net>
Signed-off-by: Simon Dudley <simon.dudley@consensys.net>
Now getting Invalid block RLP while validating block during prepareBlock Signed-off-by: Simon Dudley <simon.dudley@consensys.net>
Signed-off-by: Simon Dudley <simon.dudley@consensys.net>
Signed-off-by: Simon Dudley <simon.dudley@consensys.net>
Signed-off-by: Jiri Peinlich <jiri.peinlich@gmail.com>
Signed-off-by: Jason Frame <jason.frame@consensys.net>
…hortHexString) Signed-off-by: Simon Dudley <simon.dudley@consensys.net>
This is probably temporary measure and we will need to detect the block using a timestamp in the future The shanghai.json is useless probably now Signed-off-by: Jiri Peinlich <jiri.peinlich@gmail.com>
Signed-off-by: Jiri Peinlich <jiri.peinlich@gmail.com>
Signed-off-by: Jiri Peinlich <jiri.peinlich@gmail.com>
…pella. This commit might break post-shanghai V2 until I switch the validation depending on the fork. Signed-off-by: Simon Dudley <simon.dudley@consensys.net>
Hacky pre/post shanghai validation Serialize UInt64 toQuantityHexString instead of toShortHexString so 0 is returned as "0x0" instead of "0x" Signed-off-by: Simon Dudley <simon.dudley@consensys.net>
Signed-off-by: Simon Dudley <simon.dudley@consensys.net>
…t contain null withdrawals This means shanghai can be activated before capella which makes devnets a lot smoother, rather than having to perfectly align capella timestamp with shanghaiBlock Signed-off-by: Simon Dudley <simon.dudley@consensys.net>
…n rules Signed-off-by: Simon Dudley <simon.dudley@consensys.net>
…bled at genesis Signed-off-by: Jason Frame <jason.frame@consensys.net>
Signed-off-by: Jiri Peinlich <jiri.peinlich@gmail.com>
Signed-off-by: Jason Frame <jason.frame@consensys.net>
Signed-off-by: Jason Frame <jason.frame@consensys.net>
Signed-off-by: Jason Frame <jason.frame@consensys.net>
Signed-off-by: Jason Frame <jason.frame@consensys.net>
Add cancun timestamp and definition so getByTimestamp can be tested for correct ordering Signed-off-by: Simon Dudley <simon.dudley@consensys.net>
Signed-off-by: Jason Frame <jason.frame@consensys.net>
Signed-off-by: Jason Frame <jason.frame@consensys.net>
Signed-off-by: Jason Frame <jason.frame@consensys.net>
Signed-off-by: Jason Frame <jason.frame@consensys.net>
…idator to use getByBlockHeader Signed-off-by: Jason Frame <jason.frame@consensys.net>
Signed-off-by: Simon Dudley <simon.dudley@consensys.net>
Signed-off-by: Jason Frame <jason.frame@consensys.net>
Signed-off-by: Simon Dudley <simon.dudley@consensys.net> Signed-off-by: Simon Dudley <simon.dudley@consensys.net>
Signed-off-by: Simon Dudley <simon.dudley@consensys.net>
…called in reality though Signed-off-by: Simon Dudley <simon.dudley@consensys.net>
Signed-off-by: Jason Frame <jason.frame@consensys.net>
siladu
force-pushed
the
withdrawals_and_timestamp
branch
from
5c88f36
to
430d431
Compare
|
merged in main with the shanghaiTime code. This is now a more accurate and up-to-date Withdrawals WIP than #4552 |
Signed-off-by: Simon Dudley <simon.dudley@consensys.net>
Closed
…lock (as well as BlockBodies) Suspect the code path that receives blocks from EL peers isn't writing withdrawals to disk Signed-off-by: Simon Dudley <simon.dudley@consensys.net>
…dule and enable shanghai Signed-off-by: Simon Dudley <simon.dudley@consensys.net>
… other mods in Signed-off-by: Simon Dudley <simon.dudley@consensys.net>
jframe
force-pushed
the
withdrawals_and_timestamp
branch
from
6921b26
to
d152fbf
Compare
Closed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
PR description
DO NOT MERGE
Test branch for withdrawals & timestamp protocol schedule changes
Fixed Issue(s)
Documentation
doc-change-requiredlabel to this PR ifupdates are required.
Changelog