Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Throwaway Withdrawals Testnet Branch (withdrawal-devnet-3) #4818

Closed

Conversation

siladu
Copy link
Contributor

@siladu siladu commented Dec 14, 2022

Want to get this code onto a testnet ahead of getting it merged on main.

It's a combination of the following:

gezero and others added 30 commits December 8, 2022 17:02
Signed-off-by: Jiri Peinlich <jiri.peinlich@gmail.com>
Signed-off-by: Jiri Peinlich <jiri.peinlich@gmail.com>
Signed-off-by: Jiri Peinlich <jiri.peinlich@gmail.com>
Signed-off-by: Jiri Peinlich <jiri.peinlich@gmail.com>
Signed-off-by: Jiri Peinlich <jiri.peinlich@gmail.com>
Signed-off-by: Jiri Peinlich <jiri.peinlich@gmail.com>
Signed-off-by: Jiri Peinlich <jiri.peinlich@gmail.com>
Signed-off-by: Simon Dudley <simon.dudley@consensys.net>
Signed-off-by: Simon Dudley <simon.dudley@consensys.net>
Signed-off-by: Simon Dudley <simon.dudley@consensys.net>
Add cancun timestamp and definition so getByTimestamp can be tested for correct ordering

Signed-off-by: Simon Dudley <simon.dudley@consensys.net>
Signed-off-by: Jason Frame <jason.frame@consensys.net>
Signed-off-by: Jason Frame <jason.frame@consensys.net>
…lder

Signed-off-by: Simon Dudley <simon.dudley@consensys.net>
…valuation lazy

Signed-off-by: Simon Dudley <simon.dudley@consensys.net>

Signed-off-by: Simon Dudley <simon.dudley@consensys.net>
Signed-off-by: Simon Dudley <simon.dudley@consensys.net>

Signed-off-by: Simon Dudley <simon.dudley@consensys.net>
Signed-off-by: Simon Dudley <simon.dudley@consensys.net>

Signed-off-by: Simon Dudley <simon.dudley@consensys.net>
Signed-off-by: Simon Dudley <simon.dudley@consensys.net>

Signed-off-by: Simon Dudley <simon.dudley@consensys.net>
Signed-off-by: Simon Dudley <simon.dudley@consensys.net>
Signed-off-by: Simon Dudley <simon.dudley@consensys.net>
… in the timestamp schedule

Signed-off-by: Simon Dudley <simon.dudley@consensys.net>
…wrong schedule

This error is likely to happen and a followup PR should update getByBlockNumber to use getByBlockHeader

Signed-off-by: Simon Dudley <simon.dudley@consensys.net>
Signed-off-by: Simon Dudley <simon.dudley@consensys.net>
Signed-off-by: Simon Dudley <simon.dudley@consensys.net>
…called in reality though

Signed-off-by: Simon Dudley <simon.dudley@consensys.net>
…ntially wrong schedule"

This reverts commit 2756a9d.

Signed-off-by: Simon Dudley <simon.dudley@consensys.net>
Signed-off-by: Simon Dudley <simon.dudley@consensys.net>
…ring

Signed-off-by: Simon Dudley <simon.dudley@consensys.net>
…ultTimestampSchedule

Support includes setPublicWorldStateArchiveForPrivacyBlockProcessor and setTransactionFilter methods

Signed-off-by: Simon Dudley <simon.dudley@consensys.net>
Signed-off-by: Simon Dudley <simon.dudley@consensys.net>
siladu and others added 8 commits December 22, 2022 08:49
This reverts commit a43135f.

Signed-off-by: Simon Dudley <simon.dudley@consensys.net>
…F (maxEofVersion) in EvmSpecVersion.SHANGHAI""

This reverts commit 5543413.

Signed-off-by: Simon Dudley <simon.dudley@consensys.net>
…aiTime""

This reverts commit 2a52a78.

Signed-off-by: Simon Dudley <simon.dudley@consensys.net>
Signed-off-by: Simon Dudley <simon.dudley@consensys.net>
Signed-off-by: Simon Dudley <simon.dudley@consensys.net>
This reverts commit ddf785a.

Signed-off-by: Simon Dudley <simon.dudley@consensys.net>
… other mods in

Signed-off-by: Simon Dudley <simon.dudley@consensys.net>
* EIP-3860 Initcode Size Reference Test fixes

Fix corner cases around initcode size checking in reference tests.

Signed-off-by: Danno Ferrin <danno.ferrin@swirldslabs.com>
@siladu siladu mentioned this pull request Jan 14, 2023
Add withdrawalsRoot as part of BodyIdentifier
Add comment to avoid new issues when adding new fields to BlockBody

Co-authored-by: Gabriel Fukushima <gabrielfukushima@gmail.com>
Signed-off-by: Gabriel Fukushima <gabrielfukushima@gmail.com>
Signed-off-by: Simon Dudley <simon.dudley@consensys.net>
gezero and others added 2 commits January 16, 2023 09:47
As an example of usecase - this should make it easier to build linux/amd64 images on M1.

Signed-off-by: Jiri Peinlich <jiri.peinlich@gmail.com>

Signed-off-by: Jiri Peinlich <jiri.peinlich@gmail.com>
Co-authored-by: Sally MacFarlane <macfarla.github@gmail.com>
Signed-off-by: Simon Dudley <simon.dudley@consensys.net>
@siladu siladu changed the title Throwaway Withdrawals Testnet Branch Throwaway Withdrawals Testnet Branch (withdrawal-devnet-2) Jan 16, 2023
@siladu siladu mentioned this pull request Jan 16, 2023
27 tasks
wcgcyx and others added 7 commits January 17, 2023 14:28
Signed-off-by: Zhenyang Shi <wcgcyx@gmail.com>
Signed-off-by: Usman Saleem <usman@usmans.info>
Signed-off-by: Gabriel Fukushima <gabrielfukushima@gmail.com>
Signed-off-by: Gabriel Fukushima <gabrielfukushima@gmail.com>
Signed-off-by: Gabriel Fukushima <gabrielfukushima@gmail.com>
Signed-off-by: Simon Dudley <simon.dudley@consensys.net>
Signed-off-by: Simon Dudley <simon.dudley@consensys.net>
…lar for RLP instead of long scalar

Signed-off-by: Jason Frame <jason.frame@consensys.net>
@siladu
Copy link
Contributor Author

siladu commented Jan 17, 2023

devnet-3 changes:

  • wei -> gwei
  • engine_forkchoiceUpdatedV2 and engine_newPayloadV2: INVALID instead of INVALID_BLOCK_HASH
  • engine_forkchoiceUpdatedV2: no PoW validation
  • -38003: Invalid payload -> -32602: Invalid Params

@siladu siladu changed the title Throwaway Withdrawals Testnet Branch (withdrawal-devnet-2) Throwaway Withdrawals Testnet Branch (withdrawal-devnet-3) Jan 17, 2023
Signed-off-by: Simon Dudley <simon.dudley@consensys.net>
@siladu siladu force-pushed the shanghaitime-forkid-withdrawals-evm branch from 9f16032 to f97e694 Compare January 18, 2023 06:36
Signed-off-by: Simon Dudley <simon.dudley@consensys.net>
@siladu
Copy link
Contributor Author

siladu commented Feb 8, 2023

Throwing away...

@siladu siladu closed this Feb 8, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

8 participants