Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Forkid timestamp #4815

Closed
wants to merge 41 commits into from
Closed

Forkid timestamp #4815

wants to merge 41 commits into from

Commits on Dec 8, 2022

  1. Composition over inheritence 

    Signed-off-by: Jiri Peinlich <jiri.peinlich@gmail.com>
    @gezero @siladu
    gezero authored and siladu committed Dec 8, 2022
    Configuration menu
    Copy the full SHA
    af166e6 View commit details
    Browse the repository at this point in the history

  2. wip 

    Signed-off-by: Jiri Peinlich <jiri.peinlich@gmail.com>
    @gezero @siladu
    gezero authored and siladu committed Dec 8, 2022
    Configuration menu
    Copy the full SHA
    72b418f View commit details
    Browse the repository at this point in the history

  3. spotless 

    Signed-off-by: Jiri Peinlich <jiri.peinlich@gmail.com>
    @gezero @siladu
    gezero authored and siladu committed Dec 8, 2022
    Configuration menu
    Copy the full SHA
    2f8f7b6 View commit details
    Browse the repository at this point in the history

  4. removing unnecessary code 

    Signed-off-by: Jiri Peinlich <jiri.peinlich@gmail.com>
    @gezero @siladu
    gezero authored and siladu committed Dec 8, 2022
    Configuration menu
    Copy the full SHA
    7cfdd52 View commit details
    Browse the repository at this point in the history

  5. fixing npe 

    Signed-off-by: Jiri Peinlich <jiri.peinlich@gmail.com>
    @gezero @siladu
    gezero authored and siladu committed Dec 8, 2022
    Configuration menu
    Copy the full SHA
    3cbfc1e View commit details
    Browse the repository at this point in the history

  6. using of shanghai schedule for Reference tests 

    Signed-off-by: Jiri Peinlich <jiri.peinlich@gmail.com>
    @gezero @siladu
    gezero authored and siladu committed Dec 8, 2022
    Configuration menu
    Copy the full SHA
    2687f7e View commit details
    Browse the repository at this point in the history

  7. Using the shanghai Timestamp 

    Signed-off-by: Jiri Peinlich <jiri.peinlich@gmail.com>
    @gezero @siladu
    gezero authored and siladu committed Dec 8, 2022
    Configuration menu
    Copy the full SHA
    2d5db69 View commit details
    Browse the repository at this point in the history

  8. spotless 

    Signed-off-by: Simon Dudley <simon.dudley@consensys.net>
    @siladu
    siladu committed Dec 8, 2022
    Configuration menu
    Copy the full SHA
    31e9329 View commit details
    Browse the repository at this point in the history

  9. Minor renaming 

    Signed-off-by: Simon Dudley <simon.dudley@consensys.net>
    @siladu
    siladu committed Dec 8, 2022
    Configuration menu
    Copy the full SHA
    71417fc View commit details
    Browse the repository at this point in the history

  10. More minor renaming 

    Signed-off-by: Simon Dudley <simon.dudley@consensys.net>
    @siladu
    siladu committed Dec 8, 2022
    Configuration menu
    Copy the full SHA
    eb7dbc6 View commit details
    Browse the repository at this point in the history

  11. Add unit test for TimestampScheduleBuilder 

    Add cancun timestamp and definition so getByTimestamp can be tested for correct ordering

Signed-off-by: Simon Dudley <simon.dudley@consensys.net>
    @siladu
    siladu committed Dec 8, 2022
    Configuration menu
    Copy the full SHA
    870c84c View commit details
    Browse the repository at this point in the history

  12. validate block using correct protocol spec 

    Signed-off-by: Jason Frame <jason.frame@consensys.net>
    @jframe @siladu
    jframe authored and siladu committed Dec 8, 2022
    Configuration menu
    Copy the full SHA
    f9303bf View commit details
    Browse the repository at this point in the history

  13. create block using correct protocol spec 

    Signed-off-by: Jason Frame <jason.frame@consensys.net>
    @jframe @siladu
    jframe authored and siladu committed Dec 8, 2022
    Configuration menu
    Copy the full SHA
    d80952b View commit details
    Browse the repository at this point in the history

  14. validate fork timestamp order and more tests for TimestampScheduleBui… 

    …lder

Signed-off-by: Simon Dudley <simon.dudley@consensys.net>
    @siladu
    siladu committed Dec 8, 2022
    Configuration menu
    Copy the full SHA
    dc15325 View commit details
    Browse the repository at this point in the history

  15. Add TransitionProtocolSchedule tests and fix make unnecessary eager e… 

    …valuation lazy

Signed-off-by: Simon Dudley <simon.dudley@consensys.net>

Signed-off-by: Simon Dudley <simon.dudley@consensys.net>
    @siladu
    siladu committed Dec 8, 2022
    Configuration menu
    Copy the full SHA
    582a8ff View commit details
    Browse the repository at this point in the history

  16. Add test for ProtocolSchedule.getByBlockHeader 

    Signed-off-by: Simon Dudley <simon.dudley@consensys.net>

Signed-off-by: Simon Dudley <simon.dudley@consensys.net>
    @siladu
    siladu committed Dec 8, 2022
    Configuration menu
    Copy the full SHA
    cfc8ecf View commit details
    Browse the repository at this point in the history

  17. Added tests for TimestampSchedule and minimised visibility 

    Signed-off-by: Simon Dudley <simon.dudley@consensys.net>

Signed-off-by: Simon Dudley <simon.dudley@consensys.net>
    @siladu
    siladu committed Dec 8, 2022
    Configuration menu
    Copy the full SHA
    5cb9bc1 View commit details
    Browse the repository at this point in the history

  18. Tentatively add TimestampProtocolSpecAdapters so it can be discussed 

    Signed-off-by: Simon Dudley <simon.dudley@consensys.net>

Signed-off-by: Simon Dudley <simon.dudley@consensys.net>
    @siladu
    siladu committed Dec 8, 2022
    Configuration menu
    Copy the full SHA
    44f4631 View commit details
    Browse the repository at this point in the history

  19. Add pom checksum 

    Signed-off-by: Simon Dudley <simon.dudley@consensys.net>
    @siladu
    siladu committed Dec 8, 2022
    Configuration menu
    Copy the full SHA
    7aeaecb View commit details
    Browse the repository at this point in the history

  20. Remove TODOs 

    Signed-off-by: Simon Dudley <simon.dudley@consensys.net>
    @siladu
    siladu committed Dec 8, 2022
    Configuration menu
    Copy the full SHA
    5ad6634 View commit details
    Browse the repository at this point in the history

  21. Fixed tests - only attempt to apply modifications if we have anything… 

    … in the timestamp schedule

Signed-off-by: Simon Dudley <simon.dudley@consensys.net>
    @siladu
    siladu committed Dec 8, 2022
    Configuration menu
    Copy the full SHA
    0f251fd View commit details
    Browse the repository at this point in the history

  22. When block not found, throw instead of defaulting to the potentially … 

    …wrong schedule

This error is likely to happen and a followup PR should update getByBlockNumber to use getByBlockHeader

Signed-off-by: Simon Dudley <simon.dudley@consensys.net>
    @siladu
    siladu committed Dec 8, 2022
    Configuration menu
    Copy the full SHA
    829e83c View commit details
    Browse the repository at this point in the history

  23. Add comment 

    Signed-off-by: Simon Dudley <simon.dudley@consensys.net>
    @siladu
    siladu committed Dec 8, 2022
    Configuration menu
    Copy the full SHA
    3fb6777 View commit details
    Browse the repository at this point in the history

  24. Missed some test modifications 

    Signed-off-by: Simon Dudley <simon.dudley@consensys.net>
    @siladu
    siladu committed Dec 8, 2022
    Configuration menu
    Copy the full SHA
    2480436 View commit details
    Browse the repository at this point in the history

  25. Add timestamp to toLogString for more info, not expecting it will be … 

    …called in reality though

Signed-off-by: Simon Dudley <simon.dudley@consensys.net>
    @siladu
    siladu committed Dec 8, 2022
    Configuration menu
    Copy the full SHA
    5954d89 View commit details
    Browse the repository at this point in the history

  26. Revert "When block not found, throw instead of defaulting to the pote… 

    …ntially wrong schedule"

This reverts commit 2756a9d.

Signed-off-by: Simon Dudley <simon.dudley@consensys.net>
    @siladu
    siladu committed Dec 8, 2022
    Configuration menu
    Copy the full SHA
    56edfa7 View commit details
    Browse the repository at this point in the history

Commits on Dec 12, 2022

  1. private and final 

    Signed-off-by: Simon Dudley <simon.dudley@consensys.net>
    @siladu
    siladu committed Dec 12, 2022
    Configuration menu
    Copy the full SHA
    727325b View commit details
    Browse the repository at this point in the history

  2. Refactor TransitionUtils.getMergeContext, pull up PostMergeContext wi… 

    …ring

Signed-off-by: Simon Dudley <simon.dudley@consensys.net>
    @siladu
    siladu committed Dec 12, 2022
    Configuration menu
    Copy the full SHA
    698849e View commit details
    Browse the repository at this point in the history

  3. Add PrivacySupportingProtocolSchedule interface and implement in Defa… 

    …ultTimestampSchedule

Support includes setPublicWorldStateArchiveForPrivacyBlockProcessor and setTransactionFilter methods

Signed-off-by: Simon Dudley <simon.dudley@consensys.net>
    @siladu
    siladu committed Dec 12, 2022
    Configuration menu
    Copy the full SHA
    f4483ca View commit details
    Browse the repository at this point in the history

Commits on Dec 13, 2022

  1. final 

    Signed-off-by: Simon Dudley <simon.dudley@consensys.net>
    @siladu
    siladu committed Dec 13, 2022
    Configuration menu
    Copy the full SHA
    bf6eb04 View commit details
    Browse the repository at this point in the history

  2. Remove TimestampProtocolSpecAdapters 

    Use ProtocolSpecAdapters with a renamed field instead

Signed-off-by: Simon Dudley <simon.dudley@consensys.net>
    @siladu
    siladu committed Dec 13, 2022
    Configuration menu
    Copy the full SHA
    e1522b1 View commit details
    Browse the repository at this point in the history

Commits on Dec 14, 2022

  1. Refactor TimestampScheduleBuilder and ProtocolScheduleBuilder to use … 

    …template pattern

Add test coverage for ProtocolScheduleBuilder

Signed-off-by: Simon Dudley <simon.dudley@consensys.net>
    @siladu
    siladu committed Dec 14, 2022
    Configuration menu
    Copy the full SHA
    06813e0 View commit details
    Browse the repository at this point in the history

  2. initial implemenation of fork id logic 

    Signed-off-by: Jiri Peinlich <jiri.peinlich@gmail.com>
    @gezero @jframe
    gezero authored and jframe committed Dec 14, 2022
    Configuration menu
    Copy the full SHA
    8b5e3ed View commit details
    Browse the repository at this point in the history

  3. fix ForkIdsTest 

    Signed-off-by: Jason Frame <jason.frame@consensys.net>
    @jframe
    jframe committed Dec 14, 2022
    Configuration menu
    Copy the full SHA
    0cb8a74 View commit details
    Browse the repository at this point in the history

  4. fix unit tests 

    Signed-off-by: Jason Frame <jason.frame@consensys.net>
    @jframe
    jframe committed Dec 14, 2022
    Configuration menu
    Copy the full SHA
    f665e6f View commit details
    Browse the repository at this point in the history

Commits on Dec 15, 2022

  1. Fix more units related to ForkId fixes 

    Signed-off-by: Simon Dudley <simon.dudley@consensys.net>
    @siladu @jframe
    siladu authored and jframe committed Dec 15, 2022
    Configuration menu
    Copy the full SHA
    f19abdd View commit details
    Browse the repository at this point in the history

  2. Add some withdrawals fork ID test cases 

    Signed-off-by: Jason Frame <jason.frame@consensys.net>
    @jframe
    jframe committed Dec 15, 2022
    Configuration menu
    Copy the full SHA
    285aec2 View commit details
    Browse the repository at this point in the history

Commits on Dec 16, 2022

  1. Rename tests 

    Signed-off-by: Jason Frame <jason.frame@consensys.net>
    @jframe
    jframe committed Dec 16, 2022
    Configuration menu
    Copy the full SHA
    5bf2626 View commit details
    Browse the repository at this point in the history

Commits on Dec 19, 2022

  1. Move forkId tests to forkId package 

    Signed-off-by: Jason Frame <jason.frame@consensys.net>
    @jframe
    jframe committed Dec 19, 2022
    Configuration menu
    Copy the full SHA
    c5add6b View commit details
    Browse the repository at this point in the history

  2. comment 

    Signed-off-by: Jason Frame <jason.frame@consensys.net>
    @jframe
    jframe committed Dec 19, 2022
    Configuration menu
    Copy the full SHA
    d86f693 View commit details
    Browse the repository at this point in the history

Commits on Dec 20, 2022

  1. Refactor ForkIdManager to use a single list of forkIDs where possible 

    Signed-off-by: Jason Frame <jason.frame@consensys.net>
    @jframe
    jframe committed Dec 20, 2022
    Configuration menu
    Copy the full SHA
    4ed37bb View commit details
    Browse the repository at this point in the history