Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Forkid timestamp #4815

Closed
wants to merge 41 commits into from
Closed

Forkid timestamp #4815

wants to merge 41 commits into from

Conversation

jframe
Copy link
Contributor

@jframe jframe commented Dec 14, 2022

PR description

Fixed Issue(s)

This implements #4793

Documentation

  • I thought about documentation and added the doc-change-required label to this PR if
    updates are required.

Changelog

gezero and others added 30 commits December 8, 2022 17:02
Signed-off-by: Jiri Peinlich <jiri.peinlich@gmail.com>
Signed-off-by: Jiri Peinlich <jiri.peinlich@gmail.com>
Signed-off-by: Jiri Peinlich <jiri.peinlich@gmail.com>
Signed-off-by: Jiri Peinlich <jiri.peinlich@gmail.com>
Signed-off-by: Jiri Peinlich <jiri.peinlich@gmail.com>
Signed-off-by: Jiri Peinlich <jiri.peinlich@gmail.com>
Signed-off-by: Jiri Peinlich <jiri.peinlich@gmail.com>
Signed-off-by: Simon Dudley <simon.dudley@consensys.net>
Signed-off-by: Simon Dudley <simon.dudley@consensys.net>
Signed-off-by: Simon Dudley <simon.dudley@consensys.net>
Add cancun timestamp and definition so getByTimestamp can be tested for correct ordering

Signed-off-by: Simon Dudley <simon.dudley@consensys.net>
Signed-off-by: Jason Frame <jason.frame@consensys.net>
Signed-off-by: Jason Frame <jason.frame@consensys.net>
…lder

Signed-off-by: Simon Dudley <simon.dudley@consensys.net>
…valuation lazy

Signed-off-by: Simon Dudley <simon.dudley@consensys.net>

Signed-off-by: Simon Dudley <simon.dudley@consensys.net>
Signed-off-by: Simon Dudley <simon.dudley@consensys.net>

Signed-off-by: Simon Dudley <simon.dudley@consensys.net>
Signed-off-by: Simon Dudley <simon.dudley@consensys.net>

Signed-off-by: Simon Dudley <simon.dudley@consensys.net>
Signed-off-by: Simon Dudley <simon.dudley@consensys.net>

Signed-off-by: Simon Dudley <simon.dudley@consensys.net>
Signed-off-by: Simon Dudley <simon.dudley@consensys.net>
Signed-off-by: Simon Dudley <simon.dudley@consensys.net>
… in the timestamp schedule

Signed-off-by: Simon Dudley <simon.dudley@consensys.net>
…wrong schedule

This error is likely to happen and a followup PR should update getByBlockNumber to use getByBlockHeader

Signed-off-by: Simon Dudley <simon.dudley@consensys.net>
Signed-off-by: Simon Dudley <simon.dudley@consensys.net>
Signed-off-by: Simon Dudley <simon.dudley@consensys.net>
…called in reality though

Signed-off-by: Simon Dudley <simon.dudley@consensys.net>
…ntially wrong schedule"

This reverts commit 2756a9d.

Signed-off-by: Simon Dudley <simon.dudley@consensys.net>
Signed-off-by: Simon Dudley <simon.dudley@consensys.net>
…ring

Signed-off-by: Simon Dudley <simon.dudley@consensys.net>
…ultTimestampSchedule

Support includes setPublicWorldStateArchiveForPrivacyBlockProcessor and setTransactionFilter methods

Signed-off-by: Simon Dudley <simon.dudley@consensys.net>
Signed-off-by: Simon Dudley <simon.dudley@consensys.net>
siladu and others added 3 commits December 13, 2022 10:21
Use ProtocolSpecAdapters with a renamed field instead

Signed-off-by: Simon Dudley <simon.dudley@consensys.net>
…template pattern

Add test coverage for ProtocolScheduleBuilder

Signed-off-by: Simon Dudley <simon.dudley@consensys.net>
Signed-off-by: Jiri Peinlich <jiri.peinlich@gmail.com>
Signed-off-by: Jason Frame <jason.frame@consensys.net>
Signed-off-by: Jason Frame <jason.frame@consensys.net>
siladu and others added 3 commits December 15, 2022 11:22
Signed-off-by: Simon Dudley <simon.dudley@consensys.net>
Signed-off-by: Jason Frame <jason.frame@consensys.net>
Signed-off-by: Jason Frame <jason.frame@consensys.net>
Signed-off-by: Jason Frame <jason.frame@consensys.net>
Signed-off-by: Jason Frame <jason.frame@consensys.net>
Signed-off-by: Jason Frame <jason.frame@consensys.net>
@jframe jframe closed this Dec 20, 2022
@siladu
Copy link
Contributor

siladu commented Dec 20, 2022

Closed in favour of #4841

@siladu siladu mentioned this pull request Jan 14, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants