Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[PIE-2333] Fix trace replay block transactions #522

Conversation

matkt
Copy link
Contributor

@matkt matkt commented Mar 18, 2020

PR description

https://pegasys1.atlassian.net/browse/PIE-2333

Some fields (creationMethod, mem) are missing on the API trace_replayBlockTransactions

  • Add creationMethod field
  • Resolve missing mem field for CALL and DELEGATECALL with RETURN
  • Resolve invalid cost value for STATICCALL
  • Add new tests

Signed-off-by: Karim TAAM <karim.t2am@gmail.com>
Signed-off-by: Karim TAAM <karim.t2am@gmail.com>

# Conflicts:
#	CHANGELOG.md
Signed-off-by: Karim TAAM <karim.t2am@gmail.com>

# Conflicts:
#	CHANGELOG.md
Signed-off-by: Karim TAAM <karim.t2am@gmail.com>
Signed-off-by: Karim TAAM <karim.t2am@gmail.com>
Signed-off-by: Karim TAAM <karim.t2am@gmail.com>
Copy link
Contributor

@AbdelStark AbdelStark left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Left some comments. Otherwise looks good to me.

Signed-off-by: Karim TAAM <karim.t2am@gmail.com>
…PIE-2333-fix-trace-replay-block-transactions

Signed-off-by: Karim TAAM <karim.t2am@gmail.com>
Signed-off-by: Karim TAAM <karim.t2am@gmail.com>
@AbdelStark AbdelStark merged commit fff1f5e into hyperledger:master Mar 19, 2020
@matkt matkt deleted the feature/PIE-2333-fix-trace-replay-block-transactions branch April 24, 2020 08:20
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants