Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[23.4] Remove IBFT1 consensus mechanism #5302

Merged
merged 13 commits into from
Apr 11, 2023
Merged

[23.4] Remove IBFT1 consensus mechanism #5302

merged 13 commits into from
Apr 11, 2023

Conversation

macfarla
Copy link
Contributor

@macfarla macfarla commented Apr 4, 2023 •
edited
Loading

This feature has been deprecated and is being removed in 23.4 (that is - do not merge until all other releases have been completed and 23.4 is the next release)

Fixes #4922

  • next release is 23.4
  • acceptanceTestsNonMainnet passed in CI

@macfarla
remove controller and config
beb9951 
Signed-off-by: Sally MacFarlane <macfarla.github@gmail.com>
@macfarla
remove ibftlegacy module
6315d99 
Signed-off-by: Sally MacFarlane <macfarla.github@gmail.com>
@macfarla
remove further config options
2bcd4dd 
Signed-off-by: Sally MacFarlane <macfarla.github@gmail.com>
@macfarla
deprecation message
21b6e2f 
Signed-off-by: Sally MacFarlane <macfarla.github@gmail.com>
@macfarla
removed test file
040ad6e 
Signed-off-by: Sally MacFarlane <macfarla.github@gmail.com>
@github-actions
Copy link

github-actions bot commented Apr 4, 2023 •
edited by macfarla
Loading

  • I thought about documentation and added the doc-change-required label to this PR if updates are required.
  • I have considered running ./gradlew acceptanceTestNonMainnet locally if my PR affects non-mainnet modules.
  • I thought about the changelog and included a changelog update if required.

@macfarla
changelog update
843fa29 
Signed-off-by: Sally MacFarlane <macfarla.github@gmail.com>
@macfarla
formatting
4fad642 
Signed-off-by: Sally MacFarlane <macfarla.github@gmail.com>
@macfarla
run non-mainnet ATs just to be sure
69c7077 
Signed-off-by: Sally MacFarlane <macfarla.github@gmail.com>
@macfarla
Copy link
Contributor Author

macfarla commented Apr 4, 2023

output from starting besu with a genesis file with "ibft" ie legacy ibft. Startup is aborted.

besu --genesis-file=config/besu/genesis-ibft1.json
2023-04-04 12:24:11.033+10:00 | main | INFO  | Besu | Starting Besu
2023-04-04 12:24:11.844+10:00 | main | INFO  | Besu |
####################################################################################################
#                                                                                                  #
# Besu version 23.1.3-dev-2bcd4dd6                                                                 #
#                                                                                                  #
# Configuration:                                                                                   #
# Network: Custom genesis file specified                                                           #
# Network Id: 2017                                                                                 #
# Data storage: Forest                                                                             #
# Sync mode: Full                                                                                  #
#                                                                                                  #
# Host:                                                                                            #
# Java: openjdk-java-17                                                                            #
# Maximum heap size: 4.00 GB                                                                       #
# OS: osx-x86_64                                                                                   #
# Total memory: 16.00 GB                                                                           #
# CPU cores: 16                                                                                    #
#                                                                                                  #
####################################################################################################
2023-04-04 12:24:11.848+10:00 | main | INFO  | Besu | Connecting to 0 static nodes.
2023-04-04 12:24:11.849+10:00 | main | INFO  | Besu | Security Module: localfile
2023-04-04 12:24:12.150+10:00 | main | INFO  | Besu | Using the native implementation of alt bn128
2023-04-04 12:24:12.457+10:00 | main | INFO  | Besu | Using the native implementation of modexp
2023-04-04 12:24:12.458+10:00 | main | INFO  | Besu | Using the native implementation of the signature algorithm
2023-04-04 12:24:12.736+10:00 | main | INFO  | Besu | Using the native implementation of the blake2bf algorithm
2023-04-04 12:24:12.755+10:00 | main | INFO  | RocksDBKeyValueStorageFactory | No existing database detected at /Users/sallymacfarlane/workspace/b2/build/install/besu. Using version 1
IBFT1 (legacy) is no longer supported. Consider using IBFT2 or QBFT.

To display full help:

@jframe
Copy link
Contributor

jframe commented Apr 4, 2023

Did a search and there is usage of "ibft" in GenesisFileModule as well

gfukushima
gfukushima approved these changes Apr 4, 2023
View reviewed changes
Copy link
Contributor

@gfukushima gfukushima left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

.circleci/config.yml Outdated Show resolved Hide resolved
@macfarla
removed reference to ibft
ada097e 
Signed-off-by: Sally MacFarlane <macfarla.github@gmail.com>
@macfarla
minor edits to changelog
02eb475 
Signed-off-by: Sally MacFarlane <macfarla.github@gmail.com>
@macfarla
remove temp change to circle config
a9fab1d 
Signed-off-by: Sally MacFarlane <macfarla.github@gmail.com>
@macfarla
Copy link
Contributor Author

macfarla commented Apr 4, 2023

Did a search and there is usage of "ibft" in GenesisFileModule as well

thanks @jframe - removed

jframe
jframe approved these changes Apr 4, 2023
View reviewed changes
Copy link
Contributor

@jframe jframe left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@non-fungible-nelson
Copy link
Contributor

image 😮

@macfarla
merge
955797b 
Signed-off-by: Sally MacFarlane <macfarla.github@gmail.com>
@macfarla
Merge branch 'main' into ibft1-rm
342f5e5
@macfarla macfarla enabled auto-merge (squash) April 11, 2023 01:56
@macfarla macfarla merged commit 795b7c4 into hyperledger:main Apr 11, 2023
@macfarla macfarla deleted the ibft1-rm branch April 18, 2023 22:29
elenduuche pushed a commit to elenduuche/besu that referenced this pull request Aug 16, 2023
@macfarla @elenduuche
[23.4] Remove IBFT1 consensus mechanism (hyperledger#5302)
925e7fa 
* remove controller and config

* remove ibftlegacy module

* remove further config options

* run non-mainnet ATs just to be sure

* remove temp change to circle config

---------

Signed-off-by: Sally MacFarlane <macfarla.github@gmail.com>
eum602 pushed a commit to lacchain/besu that referenced this pull request Nov 3, 2023
@macfarla @eum602
[23.4] Remove IBFT1 consensus mechanism (hyperledger#5302)
c2aee02 
* remove controller and config

* remove ibftlegacy module

* remove further config options

* run non-mainnet ATs just to be sure

* remove temp change to circle config

---------

Signed-off-by: Sally MacFarlane <macfarla.github@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jframe jframe jframe approved these changes

@gfukushima gfukushima gfukushima approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Removal of IBFT Acceptance tests alongside legacy IBFT (23.4)
4 participants
@macfarla @jframe @non-fungible-nelson @gfukushima