Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

refactor(connector-fabric): upgrade to Fabric 2.x Node SDK #1123

Closed
petermetz opened this issue Jul 12, 2021 · 0 comments · Fixed by #1124
Closed

refactor(connector-fabric): upgrade to Fabric 2.x Node SDK #1123

petermetz opened this issue Jul 12, 2021 · 0 comments · Fixed by #1124
Assignees
@petermetz
Labels
enhancement New feature or request Fabric Security Related to existing or potential security vulnerabilities

Comments

@petermetz
Copy link
Member

Description

The Cactus packages are relying in 1.4.x Fabric SDK dependencies at the moment (even when communicating with 2.x Fabric ledgers) which is something that we need to fix by upgrading the dependency versions and then if needed create a separate Fabric connector package for 1.4.x ledgers (so that we can have the Fabric Node SDK 1.4.x dependency in there, separately).
Though the best would be if we just did not need to use the 1.4.x Fabric SDK at all.

Acceptance Criteria

  1. No trace left of the Fabric 1.4.x SDK among the dependencies (if possible)
  2. All Fabric tests are still passing both 1.4.x. and 2.x ledger-wise.
@petermetz petermetz added enhancement New feature or request Fabric Security Related to existing or potential security vulnerabilities labels Jul 12, 2021
@petermetz petermetz self-assigned this Jul 12, 2021
petermetz added a commit to petermetz/cacti that referenced this issue Jul 12, 2021
@petermetz
feat(connector-fabric): endorsing peers request arg hyperledger#1122
fe8e747 
WORK IN PROGRESS

Depends on hyperledger#1123

Fixes hyperledger#1122

Signed-off-by: Peter Somogyvari <peter.somogyvari@accenture.com>
petermetz added a commit to petermetz/cacti that referenced this issue Jul 12, 2021
@petermetz
refactor(connector-fabric): upgrade to Fabric 2.x Node SDK hyperledge…
d4adf73 
…r#1123

The Cactus packages were relying on 1.4.x Fabric SDK dependencies
prior to this change (even when communicating with 2.x Fabric ledgers)
which is something that we needed to fix by upgrading the dependency
versions.

Fixes hyperledger#1123

Signed-off-by: Peter Somogyvari <peter.somogyvari@accenture.com>
@petermetz petermetz mentioned this issue Jul 12, 2021
Merged
petermetz added a commit to petermetz/cacti that referenced this issue Jul 12, 2021
@petermetz
feat(connector-fabric): endorsing peers request arg hyperledger#1122
ecc4fd4 
WORK IN PROGRESS

Depends on hyperledger#1123

Fixes hyperledger#1122

Signed-off-by: Peter Somogyvari <peter.somogyvari@accenture.com>
petermetz added a commit to petermetz/cacti that referenced this issue Jul 13, 2021
@petermetz
refactor(connector-fabric): upgrade to Fabric 2.x Node SDK hyperledge…
b6f3b89 
…r#1123

The Cactus packages were relying on 1.4.x Fabric SDK dependencies
prior to this change (even when communicating with 2.x Fabric ledgers)
which is something that we needed to fix by upgrading the dependency
versions.

Fixes hyperledger#1123

Signed-off-by: Peter Somogyvari <peter.somogyvari@accenture.com>
petermetz added a commit to petermetz/cacti that referenced this issue Jul 13, 2021
@petermetz
feat(connector-fabric): endorsing peers request arg hyperledger#1122
3c8f800 
WORK IN PROGRESS

Depends on hyperledger#1123

Fixes hyperledger#1122

Signed-off-by: Peter Somogyvari <peter.somogyvari@accenture.com>
petermetz added a commit to petermetz/cacti that referenced this issue Jul 14, 2021
@petermetz
feat(connector-fabric): endorsing peers request arg hyperledger#1122
01a4d64 
Makes it possible to set the endorsing peers on a transaction
when submitted through the Fabric connector.

For example these values can be passed in to the new parameter
and it will set the endorsers up accordingly prior to submitting
the transaction to the ledger:
- org1.example.com
- Org1MSP
- org2.example.com
- Org2MSP

(You only need either the org domain or the msp ID, no need
to specify both of them for it to work).

For a working example, see this test case:
packages/cactus-plugin-ledger-connector-fabric/src/test/typescript/integration/fabric-v2-2-x/run-transaction-endpoint-v1.test.ts

Depends on hyperledger#1123
Depends on hyperledger#1130

Fixes hyperledger#1122

Signed-off-by: Peter Somogyvari <peter.somogyvari@accenture.com>
@petermetz petermetz mentioned this issue Jul 14, 2021
Merged
petermetz added a commit that referenced this issue Jul 21, 2021
@petermetz
refactor(connector-fabric): upgrade to Fabric 2.x Node SDK #1123
119a23a 
The Cactus packages were relying on 1.4.x Fabric SDK dependencies
prior to this change (even when communicating with 2.x Fabric ledgers)
which is something that we needed to fix by upgrading the dependency
versions.

Fixes #1123

Signed-off-by: Peter Somogyvari <peter.somogyvari@accenture.com>
petermetz added a commit to petermetz/cacti that referenced this issue Jul 22, 2021
@petermetz
feat(connector-fabric): endorsing peers request arg hyperledger#1122
b9eb74a 
Makes it possible to set the endorsing peers on a transaction
when submitted through the Fabric connector.

For example these values can be passed in to the new parameter
and it will set the endorsers up accordingly prior to submitting
the transaction to the ledger:
- org1.example.com
- Org1MSP
- org2.example.com
- Org2MSP

(You only need either the org domain or the msp ID, no need
to specify both of them for it to work).

For a working example, see this test case:
packages/cactus-plugin-ledger-connector-fabric/src/test/typescript/integration/fabric-v2-2-x/run-transaction-endpoint-v1.test.ts

Depends on hyperledger#1123
Depends on hyperledger#1130

Fixes hyperledger#1122

Signed-off-by: Peter Somogyvari <peter.somogyvari@accenture.com>
petermetz added a commit to petermetz/cacti that referenced this issue Jul 22, 2021
@petermetz
feat(connector-fabric): endorsing peers request arg hyperledger#1122
7c950b0 
Makes it possible to set the endorsing peers on a transaction
when submitted through the Fabric connector.

For example these values can be passed in to the new parameter
and it will set the endorsers up accordingly prior to submitting
the transaction to the ledger:
- org1.example.com
- Org1MSP
- org2.example.com
- Org2MSP

(You only need either the org domain or the msp ID, no need
to specify both of them for it to work).

For a working example, see this test case:
packages/cactus-plugin-ledger-connector-fabric/src/test/typescript/
integration/fabric-v2-2-x/run-transaction-endpoint-v1.test.ts

Depends on hyperledger#1123
Depends on hyperledger#1130

Fixes hyperledger#1122

Signed-off-by: Peter Somogyvari <peter.somogyvari@accenture.com>
petermetz added a commit to petermetz/cacti that referenced this issue Jul 22, 2021
@petermetz
feat(connector-fabric): endorsing peers request arg hyperledger#1122
2b97679 
Makes it possible to set the endorsing peers on a transaction
when submitted through the Fabric connector.

For example these values can be passed in to the new parameter
and it will set the endorsers up accordingly prior to submitting
the transaction to the ledger:
- org1.example.com
- Org1MSP
- org2.example.com
- Org2MSP

(You only need either the org domain or the msp ID, no need
to specify both of them for it to work).

For a working example, see this test case:
packages/cactus-plugin-ledger-connector-fabric/src/test/typescript/
integration/fabric-v2-2-x/run-transaction-endpoint-v1.test.ts

Depends on hyperledger#1123
Depends on hyperledger#1130

Fixes hyperledger#1122

Signed-off-by: Peter Somogyvari <peter.somogyvari@accenture.com>
petermetz added a commit to petermetz/cacti that referenced this issue Jul 23, 2021
@petermetz
feat(connector-fabric): endorsing peers request arg hyperledger#1122
1fa4d1f 
Makes it possible to set the endorsing peers on a transaction
when submitted through the Fabric connector.

For example these values can be passed in to the new parameter
and it will set the endorsers up accordingly prior to submitting
the transaction to the ledger:
- org1.example.com
- Org1MSP
- org2.example.com
- Org2MSP

(You only need either the org domain or the msp ID, no need
to specify both of them for it to work).

For a working example, see this test case:
packages/cactus-plugin-ledger-connector-fabric/src/test/typescript/
integration/fabric-v2-2-x/run-transaction-endpoint-v1.test.ts

Depends on hyperledger#1123
Depends on hyperledger#1130

Fixes hyperledger#1122

Signed-off-by: Peter Somogyvari <peter.somogyvari@accenture.com>
petermetz added a commit that referenced this issue Jul 23, 2021
@petermetz
feat(connector-fabric): endorsing peers request arg #1122
c6057a7 
Makes it possible to set the endorsing peers on a transaction
when submitted through the Fabric connector.

For example these values can be passed in to the new parameter
and it will set the endorsers up accordingly prior to submitting
the transaction to the ledger:
- org1.example.com
- Org1MSP
- org2.example.com
- Org2MSP

(You only need either the org domain or the msp ID, no need
to specify both of them for it to work).

For a working example, see this test case:
packages/cactus-plugin-ledger-connector-fabric/src/test/typescript/
integration/fabric-v2-2-x/run-transaction-endpoint-v1.test.ts

Depends on #1123
Depends on #1130

Fixes #1122

Signed-off-by: Peter Somogyvari <peter.somogyvari@accenture.com>
hanxu12 pushed a commit to hanxu12/cactus that referenced this issue Jul 26, 2021
@petermetz @hanxu12
feat(connector-fabric): endorsing peers request arg hyperledger#1122
42230fb 
Makes it possible to set the endorsing peers on a transaction
when submitted through the Fabric connector.

For example these values can be passed in to the new parameter
and it will set the endorsers up accordingly prior to submitting
the transaction to the ledger:
- org1.example.com
- Org1MSP
- org2.example.com
- Org2MSP

(You only need either the org domain or the msp ID, no need
to specify both of them for it to work).

For a working example, see this test case:
packages/cactus-plugin-ledger-connector-fabric/src/test/typescript/
integration/fabric-v2-2-x/run-transaction-endpoint-v1.test.ts

Depends on hyperledger#1123
Depends on hyperledger#1130

Fixes hyperledger#1122

Signed-off-by: Peter Somogyvari <peter.somogyvari@accenture.com>
Signed-off-by: hxlaf <xuhan@lafayette.edu>
RafaelAPB pushed a commit to RafaelAPB/blockchain-integration-framework that referenced this issue Mar 9, 2022
@petermetz @RafaelAPB
refactor(connector-fabric): upgrade to Fabric 2.x Node SDK hyperledge…
5173906 
…r#1123

The Cactus packages were relying on 1.4.x Fabric SDK dependencies
prior to this change (even when communicating with 2.x Fabric ledgers)
which is something that we needed to fix by upgrading the dependency
versions.

Fixes hyperledger#1123

Signed-off-by: Peter Somogyvari <peter.somogyvari@accenture.com>
RafaelAPB pushed a commit to RafaelAPB/blockchain-integration-framework that referenced this issue Mar 9, 2022
@petermetz @RafaelAPB
feat(connector-fabric): endorsing peers request arg hyperledger#1122
1dc5f24 
Makes it possible to set the endorsing peers on a transaction
when submitted through the Fabric connector.

For example these values can be passed in to the new parameter
and it will set the endorsers up accordingly prior to submitting
the transaction to the ledger:
- org1.example.com
- Org1MSP
- org2.example.com
- Org2MSP

(You only need either the org domain or the msp ID, no need
to specify both of them for it to work).

For a working example, see this test case:
packages/cactus-plugin-ledger-connector-fabric/src/test/typescript/
integration/fabric-v2-2-x/run-transaction-endpoint-v1.test.ts

Depends on hyperledger#1123
Depends on hyperledger#1130

Fixes hyperledger#1122

Signed-off-by: Peter Somogyvari <peter.somogyvari@accenture.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@petermetz petermetz

Labels
enhancement New feature or request Fabric Security Related to existing or potential security vulnerabilities
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

refactor(connector-fabric): upgrade to Fabric 2.x Node SDK #1123 petermetz/cacti
1 participant
@petermetz