refactor(connector-fabric): upgrade to Fabric 2.x Node SDK #1123 #1124
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
petermetz
added
enhancement
…r#1123 The Cactus packages were relying on 1.4.x Fabric SDK dependencies prior to this change (even when communicating with 2.x Fabric ledgers) which is something that we needed to fix by upgrading the dependency versions. Fixes hyperledger#1123 Signed-off-by: Peter Somogyvari <peter.somogyvari@accenture.com>
petermetz
added a commit
to petermetz/cacti
that referenced
this pull request
Jul 14, 2021
…#1130 Introduces a new, optional (for now) parameter on the run tx endpoint's request object called gatewayOptions which is capable of including everything that one needs to instantiate a gateway object of the underlying Fabric Node SDK. This change makes it possible to not need the keychain plugin at all when someone does not need/want it. Fixes hyperledger#1130 Depends on hyperledger#1124 Signed-off-by: Peter Somogyvari <peter.somogyvari@accenture.com>
takeutak
approved these changes
Jul 15, 2021
Codecov Report
@@ Coverage Diff @@
## main #1124 +/- ##
=======================================
Coverage 73.19% 73.19%
=======================================
Files 246 246
Lines 8617 8619 +2
Branches 996 996
=======================================
+ Hits 6307 6309 +2
Misses 1779 1779
Partials 531 531
Continue to review full report at Codecov.
|
|
@jscode017 FYI This just got merged, should make things easier on your ODAP work as well. |
petermetz
added a commit
to petermetz/cacti
that referenced
this pull request
Jul 22, 2021
…#1130 Introduces a new, optional (for now) parameter on the run tx endpoint's request object called gatewayOptions which is capable of including everything that one needs to instantiate a gateway object of the underlying Fabric Node SDK. This change makes it possible to not need the keychain plugin at all when someone does not need/want it. Fixes hyperledger#1130 Depends on hyperledger#1124 Signed-off-by: Peter Somogyvari <peter.somogyvari@accenture.com>
petermetz
added a commit
that referenced
this pull request
Jul 22, 2021
Introduces a new, optional (for now) parameter on the run tx endpoint's request object called gatewayOptions which is capable of including everything that one needs to instantiate a gateway object of the underlying Fabric Node SDK. This change makes it possible to not need the keychain plugin at all when someone does not need/want it. Fixes #1130 Depends on #1124 Signed-off-by: Peter Somogyvari <peter.somogyvari@accenture.com>
hanxu12
pushed a commit
to hanxu12/cactus
that referenced
this pull request
Jul 26, 2021
…#1130 Introduces a new, optional (for now) parameter on the run tx endpoint's request object called gatewayOptions which is capable of including everything that one needs to instantiate a gateway object of the underlying Fabric Node SDK. This change makes it possible to not need the keychain plugin at all when someone does not need/want it. Fixes hyperledger#1130 Depends on hyperledger#1124 Signed-off-by: Peter Somogyvari <peter.somogyvari@accenture.com> Signed-off-by: hxlaf <xuhan@lafayette.edu>
RafaelAPB
pushed a commit
to RafaelAPB/blockchain-integration-framework
that referenced
this pull request
Mar 9, 2022
…#1130 Introduces a new, optional (for now) parameter on the run tx endpoint's request object called gatewayOptions which is capable of including everything that one needs to instantiate a gateway object of the underlying Fabric Node SDK. This change makes it possible to not need the keychain plugin at all when someone does not need/want it. Fixes hyperledger#1130 Depends on hyperledger#1124 Signed-off-by: Peter Somogyvari <peter.somogyvari@accenture.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The Cactus packages were relying on 1.4.x Fabric SDK dependencies
prior to this change (even when communicating with 2.x Fabric ledgers)
which is something that we needed to fix by upgrading the dependency
versions.
Fixes #1123
Signed-off-by: Peter Somogyvari peter.somogyvari@accenture.com