feat(core-api): add weaver protobuf codegen #1556 #1759
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@VRamakrishna What do you think of this? If it looks good I'll set up the auto-publishing github workflow for a crate. |
petermetz
force-pushed
the
petermetz/issue1556
branch
from
287abee
to
a5520fd
Compare
packages/cactus-core-api/src/main/rust/generated/proto-rs/common.access_control.rs
Outdated
Show resolved
Hide resolved
|
How do we now build the relay as a standalone component using the code generated from the protos? Also, can you add a |
petermetz
force-pushed
the
petermetz/issue1556
branch
from
a5520fd
to
49dc56f
Compare
@VRamakrishna Adding the readme in the scope of another issue that we had open for a while, stay tuned for the follow-up PR with that: #833 Added a Makefile so now you can run |
Rust code now gets generated from the Weaver protocol buffer definitions Next step is to have the automated publishing set up. To test the rust build, you need to run either one of the following: `yarn lerna run proto:protoc-gen-rust` (from the project root) or a regular cargo build from the core-api package directory, e.g.: ```sh cd packages/cactus-core-api/ cargo build ``` Fixes hyperledger#1556 Signed-off-by: Peter Somogyvari <peter.somogyvari@accenture.com>
petermetz
force-pushed
the
petermetz/issue1556
branch
from
49dc56f
to
794207a
Compare
petermetz
requested review from
takeutak,
izuru0 and
jagpreetsinghsasan
and removed request for
jonathan-m-hamilton
petermetz
added
Core_API
takeutak
approved these changes
Jan 20, 2022
VRamakrishna
approved these changes
Jan 20, 2022
jagpreetsinghsasan
approved these changes
Jan 21, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
feat(core-api): add weaver protobuf codegen #1556
Rust code now gets generated from the Weaver protocol buffer definitions
Next step is to have the automated publishing set up.
To test the rust build, you need to run either one of the following:
yarn lerna run proto:protoc-gen-rust(from the project root)or a regular cargo build from the core-api package directory, e.g.:
cd packages/cactus-core-api/ cargo buildFixes #1556
Signed-off-by: Peter Somogyvari peter.somogyvari@accenture.com