docs(cactus-core-api): add README file #1794
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Depends on hyperledger#1556 - feat(core-api): add weaver protobuf codegen Fixes hyperledger#833 Signed-off-by: Peter Somogyvari <peter.somogyvari@accenture.com>
petermetz
requested review from
izuru0,
jagpreetsinghsasan,
takeutak and
VRamakrishna
petermetz
added
Core_API
takeutak
approved these changes
Jan 20, 2022
VRamakrishna
approved these changes
Jan 20, 2022
|
This PR/issue depends on:
|
|
Thanks for this. Sorry, I haven’t been very productive since Friday, as I got a new work laptop and have been trying to migrate my stuff to it, a process that’s been slow. I’ll get to the JS and Java builds for the Weaver protobufs soon.
Rama
From: Peter Somogyvari ***@***.***>
Sent: 23 January 2022 07:42
To: hyperledger/cactus ***@***.***>
Cc: Venkatraman Ramakrishna ***@***.***>; Review requested ***@***.***>
Subject: [EXTERNAL] Re: [hyperledger/cactus] docs(cactus-core-api): add README file (PR #1794)
Merged #1794 into main. — Reply to this email directly, view it on GitHub, or unsubscribe. Triage notifications on the go with GitHub Mobile for iOS or Android. You are receiving this because your review was requested.Message ID: ZjQcmQRYFpfptBannerStart
This Message Is From an External Sender
This message came from outside your organization.
ZjQcmQRYFpfptBannerEnd
Merged #1794<#1794> into main.
—
Reply to this email directly, view it on GitHub<#1794 (comment)>, or unsubscribe<https://github.com/notifications/unsubscribe-auth/ADRS2E4LTHSKGTR2XMA4CTTUXNPWXANCNFSM5MILOF7A>.
Triage notifications on the go with GitHub Mobile for iOS<https://apps.apple.com/app/apple-store/id1477376905?ct=notification-email&mt=8&pt=524675> or Android<https://play.google.com/store/apps/details?id=com.github.android&referrer=utm_campaign%3Dnotification-email%26utm_medium%3Demail%26utm_source%3Dgithub>.
You are receiving this because your review was requested.Message ID: ***@***.***>
|
|
@VRamakrishna Absolutely no problem, thank you very much for the effort and let me know if I can help with anything as usual! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Depends on #1556 - feat(core-api): add weaver protobuf codegen
Fixes #833
Signed-off-by: Peter Somogyvari peter.somogyvari@accenture.com