fix(cactus-example-discounted-asset-trade): enable tsconfig strict flag and fix all the warnings #2157
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
rwat17
requested review from
petermetz,
takeutak,
izuru0,
jagpreetsinghsasan and
sandeepnRES
as code owners
|
@izuru please review |
izuru0
reviewed
Sep 12, 2022
examples/cactus-example-discounted-asset-trade/balance-management.ts
Outdated
Show resolved
Hide resolved
...tsconfig strict flag and fix all the warnings - Fixed all warnings when strict flag is enabled Closes: hyperledger#2145 Signed-off-by: Tomasz Awramski <tomasz.awramski@fujitsu.com>
rwat17
force-pushed
the
asset-trade-refactor
branch
from
6ee08f3
to
2652dfd
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes: #2145
Signed-off-by: Tomasz Awramski tomasz.awramski@fujitsu.com