fix(cactus-example-discounted-asset-trade): enable

...tsconfig strict flag and fix all the warnings

- Fixed all warnings when strict flag is enabled

Closes: #2145

Signed-off-by: Tomasz Awramski <tomasz.awramski@fujitsu.com>

examples/cactus-example-discounted-asset-trade/balance-management.ts

@@ -12,16 +12,14 @@ import {
   VerifierFactoryConfig,
 } from "@hyperledger/cactus-verifier-client";
 
-const fs = require("fs");
-const path = require("path");
-const config: any = ConfigUtil.getConfig();
+const config: any = ConfigUtil.getConfig() as any;
 import { getLogger } from "log4js";
 const moduleName = "BalanceManagement";
 const logger = getLogger(`${moduleName}`);
 logger.level = config.logLevel;
 
 export class BalanceManagement {
-  private connectInfo: LPInfoHolder = null; // connection information
+  private connectInfo: LPInfoHolder | null = null; // connection information
   private readonly verifierFactory: VerifierFactory;
 
   constructor() {
@@ -32,19 +30,18 @@ export class BalanceManagement {
     );
   }
 
-  getBalance(account: string): Promise<any> {
+  getBalance(
+    account: string,
+  ): Promise<{
+    status: number;
+    amount: number;
+  }> {
     return new Promise((resolve, reject) => {
       // for LedgerOperation
-      // const execData = {"referedAddress": account};
-      // const ledgerOperation: LedgerOperation = new LedgerOperation("getNumericBalance", "", execData);
 
-      // for Neo
       const contract = {}; // NOTE: Since contract does not need to be specified, specify an empty object.
       const method = { type: "web3Eth", command: "getBalance" };
-      const template = "default";
       const args = { args: [account] };
-      // const method = "default";
-      // const args = {"method": {type: "web3Eth", command: "getBalance"},"args": {"args": [account]}};
 
       this.verifierFactory
         .getVerifier("84jUisrs")

examples/cactus-example-discounted-asset-trade/balance.ts

@@ -10,8 +10,6 @@ import { ConfigUtil } from "@hyperledger/cactus-cmd-socketio-server";
 import { RIFError } from "@hyperledger/cactus-cmd-socketio-server";
 import { BalanceManagement } from "./balance-management";
 
-const fs = require("fs");
-const path = require("path");
 const config: any = ConfigUtil.getConfig();
 import { getLogger } from "log4js";
 const moduleName = "balance";
@@ -35,7 +33,9 @@ router.get("/:account", (req: Request, res: Response, next: NextFunction) => {
         logger.error(err);
       });
   } catch (err) {
-    logger.error(`##err name: ${err.constructor.name}`);
+    if (err instanceof Error) {
+      logger.error(`##err name: ${err.constructor.name}`);
+    }
 
     if (err instanceof RIFError) {
       logger.debug(`##catch RIFError, ${err.statusCode}, ${err.message}`);