Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ci(coverage): add total typescript code coverage statistics #3285

Merged
merged 1 commit into from
Jul 13, 2024

Conversation

aldousalvarez
Copy link
Contributor

@aldousalvarez aldousalvarez commented May 31, 2024

Commit to be reviewed


ci(coverage): add total typescript code coverage statistics

Primary Changes
----------------
1. Updated the ci.yaml and ci.sh to introduce total typescript code coverage statistics using jest and istanbul-merge

Fixes #2661

Pull Request Requirements

  • Rebased onto upstream/main branch and squashed into single commit to help maintainers review it more efficient and to avoid spaghetti git commit graphs that obfuscate which commit did exactly what change, when and, why.
  • Have git sign off at the end of commit message to avoid being marked red. You can add -s flag when using git commit command. You may refer to this link for more information.
  • Follow the Commit Linting specification. You may refer to this link for more information.

Character Limit

  • Pull Request Title and Commit Subject must not exceed 72 characters (including spaces and special characters).
  • Commit Message per line must not exceed 80 characters (including spaces and special characters).

A Must Read for Beginners
For rebasing and squashing, here's a must read guide for beginners.

Copy link
Member

@petermetz petermetz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@aldousalvarez Thank you very much for this! It's looking very good so far, I just have some questions above^^

.github/workflows/ci.yaml Outdated Show resolved Hide resolved
.github/workflows/ci.yaml Outdated Show resolved Hide resolved
.github/workflows/ci.yaml Outdated Show resolved Hide resolved
@aldousalvarez aldousalvarez force-pushed the aldousalvarez/issue2661 branch 5 times, most recently from a775e73 to f53931f Compare June 20, 2024 00:44
Copy link
Member

@petermetz petermetz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@aldousalvarez
Copy link
Contributor Author

Hello @petermetz already done with the requested changes. Thank you. It will not run on this pull request but it will run on the default branch which is main once it gets merged.

Copy link
Member

@petermetz petermetz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hello @petermetz already done with the requested changes. Thank you. It will not run on this pull request but it will run on the default branch which is main once it gets merged.

@aldousalvarez Thank you for the updates! I agree it's time for us to take a look at it and see if it works on main. Fingers crossed! :-)

@jagpreetsinghsasan
Copy link
Contributor

LGTM too

Copy link
Member

@petermetz petermetz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@aldousalvarez Please fix the merge conflicts and then we are good to go! (Make sure to pass it back for review once the conflicts are fixed)

@aldousalvarez
Copy link
Contributor Author

@petermetz Already fixed the merge conflict. Thank you!

Copy link
Member

@petermetz petermetz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@aldousalvarez It might've happened again with another PR in the meantime, please fix again :-)

image

Primary Changes
----------------
1. Updated the ci.yaml and ci.sh to introduce total typescript code coverage
   statistics using jest and istanbul-merge
2. Added Codecov to cspell.json

Fixes hyperledger#2661

Signed-off-by: aldousalvarez <aldousss.alvarez@gmail.com>
@aldousalvarez
Copy link
Contributor Author

Hello @petermetz just fixed the merged conflicts. Thank you

Copy link
Member

@petermetz petermetz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@aldousalvarez LGTM, thank you!

@petermetz petermetz merged commit c7fce88 into hyperledger:main Jul 13, 2024
142 of 145 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

ci(coverage): add total typescript code coverage statistics
5 participants