compositeRate issue

[wvans123]

about RateControl's compositeRate roundConfig issus

Context

I can't find the roundConfig in rateInterface but it is used in compositeRate.js and get error message

Expected Behavior

success and get some message

Actual Behavior

return error meesage about this.roundConfig(in compositeRate.js row 120,135...)

Possible Fix

may be in rateInterface define a property; but another issue also exist in new RateControl(arg0,arg1,arg2,...) error (in row 149,159)

Steps to Reproduce

Existing issues

• Stack Overflow issues
• GitHub Issues
• Rocket Chat history

Context

Your Environment

• Version used: 0.4.2
• Environment name and version (e.g. Chrome 39, node.js 5.4): nodejs v8.17.0
• Operating System and version (desktop or mobile):linux 4.15.0-162-generic
• Link to your project:

[aklenik]

@wvans123 Can you please share your benchmark configuration file content?

[wvans123]

@aklenik thank you for answering my question, this is my benchmark configuration

simpleArgs: &simple-args
initialMoney: 10000
moneyToTransfer: 100
numberOfAccounts: &number-of-accounts 1000

test:
    name: simple
description: >-
    This is an example benchmark for Caliper, to test the backend DLT's
    performance with simple account opening & querying transactions.
    workers:
        type: local
        number: 1
    rounds:
        - label: open
        description: >-
            Test description for the opening of an account through the deployed
            contract.
        txDuration: 30
        rateControl:{
            type: "composite-rate"
            opts:{
                "weights" : [1,2],
                "rateControllers" : [
                    {
                        "type" : "fixed-rate",
                        "opts" : {"tps" : 200}
                    },
                    {
                        "type" : "fixed-rate",
                        "opts" : {"tps" : 400}
                    }
                ],
                "logChange" : true
            }
       } 
        workload:
            module: benchmarks/scenario/simple/open.js
            arguments: *simple-args

[aklenik]

There are several bugs indeed:

1. A name refactoring from roundConfig to testMessage in the base RateInterface was not applied in the CompositeRateController class.
2. Creation of sub-controllers were not honoring the new RateControl API

[LPmofeng]

@aklenik thank you for answering my question, this is my benchmark configuration

simpleArgs: &simple-args
initialMoney: 10000
moneyToTransfer: 100
numberOfAccounts: &number-of-accounts 1000

test:
    name: simple
description: >-
    This is an example benchmark for Caliper, to test the backend DLT's
    performance with simple account opening & querying transactions.
    workers:
        type: local
        number: 1
    rounds:
        - label: open
        description: >-
            Test description for the opening of an account through the deployed
            contract.
        txDuration: 30
        rateControl:{
            type: "composite-rate"
            opts:{
                "weights" : [1,2],
                "rateControllers" : [
                    {
                        "type" : "fixed-rate",
                        "opts" : {"tps" : 200}
                    },
                    {
                        "type" : "fixed-rate",
                        "opts" : {"tps" : 400}
                    }
                ],
                "logChange" : true
            }
       } 
        workload:
            module: benchmarks/scenario/simple/open.js
            arguments: *simple-args

Has this issue been resolved?