Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Azure pipelines build #1105

Merged
merged 1 commit into from
Dec 31, 2020
Merged

Azure pipelines build #1105

merged 1 commit into from
Dec 31, 2020

Conversation

nklincoln
Copy link
Contributor

Contributes to #1102

Introduces Azure pipeline build

  • unit tests
  • integration tests

Signed-off-by: nkl199@yahoo.co.uk nkl199@yahoo.co.uk

Copy link
Contributor

@aklenik aklenik left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Two non-blocking comments only

.travis.yml Outdated
@@ -10,7 +10,7 @@ dist: xenial
before_install: |
set -ev
set -o pipefail
npm install -g @alrra/travis-scripts
npm install -g @alrra/build-scripts
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Is this rename intentional?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🤔 don't actually remember changing this on, i will revert the change

# Node.js
# Build a general Node.js project with npm.
# Add steps that analyze code, save build artifacts, deploy, and more:
# https://docs.microsoft.com/azure/devops/pipelines/languages/javascript
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Do we need license in yaml files?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks to be a bit of self publication from microsoft - it was an autogenerated document

Signed-off-by: nkl199@yahoo.co.uk <nkl199@yahoo.co.uk>
@nklincoln nklincoln merged commit bc436e8 into hyperledger:master Dec 31, 2020
@nklincoln nklincoln deleted the azure-build branch December 31, 2020 09:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants