Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fabric Gateway connector implementation: PeerGateway.js implementation + unit tests #1270

Merged
merged 1 commit into from
Apr 1, 2022
Merged

Fabric Gateway connector implementation: PeerGateway.js implementation + unit tests #1270

merged 1 commit into from
Apr 1, 2022

Conversation

fraVlaca
Copy link
Contributor

@fraVlaca fraVlaca commented Mar 17, 2022 •
edited

Added main logic for the new peer-gateaway connector with unit tests

@fraVlaca fraVlaca changed the title added main logic for the new peer-gateaway connector including unit t… added main logic for the new peer-gateaway connector with unit tests Mar 17, 2022
@fraVlaca fraVlaca closed this Mar 17, 2022
@fraVlaca fraVlaca reopened this Mar 17, 2022
@davidkel davidkel self-requested a review March 18, 2022 19:41
@davidkel
Copy link
Contributor

davidkel commented Mar 18, 2022 •
edited

@fraVlaca as per #1270 (comment)
if you don't want it merged then suggest you convert it to a draft and remove the comment. At the moment I don't know whether it's ready to be reviewed or not.

@fraVlaca fraVlaca changed the title added main logic for the new peer-gateaway connector with unit tests Fabric Gateway connector implementation itselft: PeerGateway.js implementation + unit tests Mar 21, 2022
@fraVlaca fraVlaca changed the title Fabric Gateway connector implementation itselft: PeerGateway.js implementation + unit tests Fabric Gateway connector implementation: PeerGateway.js implementation + unit tests Mar 21, 2022
@fraVlaca fraVlaca mentioned this pull request Mar 21, 2022
Closed
davidkel
davidkel requested changes Mar 22, 2022
View reviewed changes
Copy link
Contributor

@davidkel davidkel left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Some initial comments

packages/caliper-fabric/lib/connector-versions/peer-gateway/PeerGateway.js Outdated Show resolved Hide resolved
packages/caliper-fabric/lib/connector-versions/peer-gateway/PeerGateway.js Outdated Show resolved Hide resolved
packages/caliper-fabric/lib/connector-versions/peer-gateway/PeerGateway.js Outdated Show resolved Hide resolved
packages/caliper-fabric/lib/connector-versions/peer-gateway/PeerGateway.js Outdated Show resolved Hide resolved
packages/caliper-fabric/lib/connector-versions/peer-gateway/PeerGateway.js Outdated Show resolved Hide resolved
packages/caliper-fabric/lib/connector-versions/peer-gateway/PeerGateway.js Outdated Show resolved Hide resolved
packages/caliper-fabric/lib/connector-versions/peer-gateway/PeerGateway.js Outdated Show resolved Hide resolved
packages/caliper-fabric/lib/connector-versions/peer-gateway/PeerGateway.js Outdated Show resolved Hide resolved
packages/caliper-fabric/lib/connector-versions/peer-gateway/PeerGateway.js Outdated Show resolved Hide resolved
packages/caliper-fabric/lib/connector-configuration/ConnectionProfileDefinition.js Outdated Show resolved Hide resolved
@fraVlaca fraVlaca force-pushed the gateway branch 2 times, most recently from 5f269ff to d605b24 Compare March 24, 2022 18:35
davidkel
davidkel requested changes Mar 25, 2022
View reviewed changes
Copy link
Contributor

@davidkel davidkel left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looking good, some minor points and improvements

packages/caliper-fabric/lib/connector-versions/peer-gateway/PeerGateway.js Outdated Show resolved Hide resolved
packages/caliper-fabric/lib/connector-versions/peer-gateway/PeerGateway.js Outdated Show resolved Hide resolved
packages/caliper-fabric/lib/connector-versions/peer-gateway/PeerGateway.js Outdated Show resolved Hide resolved
packages/caliper-fabric/lib/connector-versions/peer-gateway/PeerGateway.js Outdated Show resolved Hide resolved
packages/caliper-fabric/lib/connector-versions/peer-gateway/PeerGateway.js Outdated Show resolved Hide resolved
packages/caliper-fabric/test/sample-configs/NetworkConfigNotMutual.yaml Outdated Show resolved Hide resolved
packages/caliper-fabric/test/sample-configs/Org2ConnectionProfile.yaml Outdated Show resolved Hide resolved
packages/caliper-fabric/test/sample-configs/Org2ConnectionProfile.yaml Outdated Show resolved Hide resolved
packages/caliper-fabric/test/sample-configs/Org2ConnectionProfile.yaml Outdated Show resolved Hide resolved
packages/caliper-fabric/test/sample-configs/Org2ConnectionProfile.yaml Outdated Show resolved Hide resolved
@fraVlaca fraVlaca force-pushed the gateway branch 2 times, most recently from 4418ebc to 3ec0a95 Compare March 30, 2022 07:56
@fraVlaca fraVlaca requested a review from davidkel March 30, 2022 08:57
davidkel
davidkel requested changes Mar 30, 2022
View reviewed changes
Copy link
Contributor

@davidkel davidkel left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Sorry, some more changes required

packages/caliper-fabric/lib/connector-versions/peer-gateway/PeerGateway.js Outdated Show resolved Hide resolved
packages/caliper-fabric/lib/connector-versions/peer-gateway/PeerGateway.js Outdated Show resolved Hide resolved
packages/caliper-fabric/lib/connector-versions/peer-gateway/PeerGateway.js Outdated Show resolved Hide resolved
packages/caliper-fabric/lib/connector-versions/peer-gateway/PeerGateway.js Show resolved Hide resolved
packages/caliper-fabric/lib/connector-versions/peer-gateway/PeerGateway.js Outdated Show resolved Hide resolved
packages/caliper-fabric/test/sample-configs/Org2ConnectionProfile.yaml Outdated Show resolved Hide resolved
packages/caliper-fabric/test/sample-configs/Org2StaticConnProfile.yaml Outdated Show resolved Hide resolved
packages/caliper-fabric/test/sample-configs/NetworkConfigNotMutual.yaml Outdated Show resolved Hide resolved
packages/caliper-fabric/test/connector-versions/peer-gateway/PeerGateway.js Outdated Show resolved Hide resolved
packages/caliper-fabric/test/connector-versions/peer-gateway/PeerGateway.js Outdated Show resolved Hide resolved
@fraVlaca fraVlaca requested a review from davidkel March 31, 2022 12:36
davidkel
davidkel requested changes Apr 1, 2022
View reviewed changes
Copy link
Contributor

@davidkel davidkel left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Almost there

@fraVlaca
added main logic for the new peer-gateaway connector including unit t…
5c31d6e 
…ests

+ added minor changes to the connectionProfileDefinition

Signed-off-by: fraVlaca <ocsenarf@outlook.com>
@fraVlaca fraVlaca requested a review from davidkel April 1, 2022 14:54
davidkel
davidkel reviewed Apr 1, 2022
View reviewed changes
packages/caliper-fabric/test/connector-versions/peer-gateway/PeerGateway.js
clock.restore();
});

it('should pass the default timeout in the gateway options', async () => {
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

duplicate test

davidkel
davidkel approved these changes Apr 1, 2022
View reviewed changes
Copy link
Contributor

@davidkel davidkel left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@davidkel davidkel merged commit a372f18 into hyperledger:main Apr 1, 2022
@davidkel davidkel linked an issue Apr 8, 2022 that may be closed by this pull request
Add a new fabric connector to utilise the new peer gateway api #1205
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@davidkel davidkel davidkel approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Add a new fabric connector to utilise the new peer gateway api
2 participants
@fraVlaca @davidkel