Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Resend tx when it fails on ethereum #1506

Closed
wants to merge 2 commits into from
Closed

Conversation

NickSneo
Copy link

Checklist

  • A link to the issue/user story that the pull request relates to
  • How to recreate the problem without the fix
  • Design of the fix
  • How to prove that the fix works
  • Automated tests that prove the fix keeps on working
  • Documentation - any JSDoc, website, or Stackoverflow answers?

Issue/User story

Steps to Reproduce

Existing issues

Design of the fix

Validation of the fix

Automated Tests

What documentation has been provided for this pull request

@NickSneo NickSneo requested a review from a team as a code owner October 24, 2023 10:13
@codecov
Copy link

codecov bot commented Oct 24, 2023

Codecov Report

Merging #1506 (755d260) into main (8cef10c) will not change coverage.
The diff coverage is n/a.

❗ Current head 755d260 differs from pull request most recent head 639154e. Consider uploading reports for the commit 639154e to get more accurate results

@@           Coverage Diff           @@
##             main    #1506   +/-   ##
=======================================
  Coverage   55.89%   55.89%           
=======================================
  Files         105      105           
  Lines        4507     4507           
  Branches      688      688           
=======================================
  Hits         2519     2519           
  Misses       1435     1435           
  Partials      553      553           
Flag Coverage Δ
caliper-core 44.98% <ø> (ø)
caliper-fabric 80.46% <ø> (ø)
generator-caliper 83.62% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

Signed-off-by: Nischal Sharma <nischal@web3labs.com>
Signed-off-by: Nischal Sharma <nischal@web3labs.com>
Copy link
Contributor

@davidkel davidkel left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'm not sure what this will achieve, caliper is designed to track success and failure of individual transations so why mark it as a failure then retry ? Also there is the potential for this to resend repeatedly as there is no logic to limit the amount of resend sent before failing completely.

If you could raise an isssue to discuss the particular issue you are seeing and the benefit/reasoning behind resending the transaction on a failure (rather than having workloads handle this for example) then it it can be moved forward but as it stands I don't think this change is appropriate.

@davidkel
Copy link
Contributor

Closing as no response from submitter

@davidkel davidkel closed this Feb 19, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants