Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Temporarily revert publish to using node 16.x to fix broken publish #1520

Merged
merged 1 commit into from
Mar 25, 2024

Conversation

davidkel
Copy link
Contributor

This is more of a case of quickly dropping down to an older version of npm so that it will fix the publish action.

Ideally we want to move to a supported version of node and address the issue that comes with that version of npm to perform a publish. It could be

  1. move to an older version of npm (ie that one that comes with node 16), but this is not ideal
  2. move to a newer version of npm as it may be an issue with the version that came with node 18, but this isn't likely
  3. look at the npm publish command to see what needs to be done to make it work.

This is more of a case of quickly dropping down to an older version of
`npm` so that it will fix the publish action.

Ideally we want to move to a supported version of node and address the
issue that comes with that version of npm to perform a publish. It could
be

1. move to an older version of npm (ie that one that comes with node
16), but this is not ideal
2. move to a newer version of npm as it may be an issue with the version
that came with node 18, but this isn't likely
3. look at the npm publish command to see what needs to be done to make
it work.

Signed-off-by: Dave Kelsey <d_kelsey@uk.ibm.com>
@davidkel davidkel requested a review from a team as a code owner March 25, 2024 13:23
Copy link
Contributor

@aklenik aklenik left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yeah, the publishing logic should be updated to the newest npm version, and probably some debug log should be emitted by the script, because the info level doesn't tell us much

@aklenik aklenik merged commit 7477c70 into hyperledger:main Mar 25, 2024
9 checks passed
@davidkel davidkel deleted the revertpublish branch May 1, 2024 08:08
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants