Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

broken-link-fix #1522

Closed
wants to merge 2 commits into from
Closed

Conversation

saksham-tomer
Copy link

Checklist

  • A link to the issue/user story that the pull request relates to
  • How to recreate the problem without the fix
  • Design of the fix
  • How to prove that the fix works
  • Automated tests that prove the fix keeps on working
  • Documentation - any JSDoc, website, or Stackoverflow answers?

Issue/User story

issue #1518
Broken PSWG whitepaper link in the README.md file for the

Steps to Reproduce

  1. Open the README.md file
  2. Click on the PSWG whitepaper link

Design of the fix

Broken link

image

Fixed link

image

@saksham-tomer saksham-tomer requested a review from a team as a code owner March 25, 2024 14:43
Copy link
Contributor

@aklenik aklenik left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please include the DCO sign-off in your commit, we can't merge the PR without it.

Also, please keep the * as the enumeration symbol, changing it just introduces noise to the PR.

Signed-off-by: Saksham Tomer <132002655+saksham-tomer@users.noreply.github.com>
@codecov-commenter
Copy link

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 55.85%. Comparing base (7477c70) to head (1a5dfe8).

❗ Current head 1a5dfe8 differs from pull request most recent head b5608a0. Consider uploading reports for the commit b5608a0 to get more accurate results

Additional details and impacted files
@@           Coverage Diff           @@
##             main    #1522   +/-   ##
=======================================
  Coverage   55.85%   55.85%           
=======================================
  Files         105      105           
  Lines        4510     4510           
  Branches      689      689           
=======================================
  Hits         2519     2519           
  Misses       1437     1437           
  Partials      554      554           
Flag Coverage Δ
caliper-core 44.94% <ø> (ø)
caliper-fabric 80.46% <ø> (ø)
generator-caliper 83.62% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@saksham-tomer
Copy link
Author

Please include the DCO sign-off in your commit, we can't merge the PR without it.

Also, please keep the * as the enumeration symbol, changing it just introduces noise to the PR.

Thank you for the feedback. I have added the DCO and changed the enumeration symbol back to *. I hope you can merge the pr.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants