caliper-core: add tests for Message classes
#1561
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
9 tasks
|
@aklenik Can you take a look |
|
On a quick glance, these seem ok to me, but really want @aklenik to take a look as he is more familiar with this part of the code I think |
davidkel
reviewed
May 9, 2024
| }) | ||
| }) | ||
|
|
||
| describe("forRecipient", () => { |
There was a problem hiding this comment.
We need tests to show that it returns false as well
There was a problem hiding this comment.
My bad for missing this case! I have updated the test suite for the same. Thanks!
davidkel
requested changes
May 9, 2024
Signed-off-by: Eshaan Aggarwal <96648934+EshaanAgg@users.noreply.github.com>
Signed-off-by: Eshaan Aggarwal <96648934+EshaanAgg@users.noreply.github.com>
davidkel
approved these changes
May 15, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR introduces the tests for the base
Messageclass incaliper-core, and then introduces three similar test suites for the constructors of three types of messages. When approved, I can work on adding similar tests for all the message classes.Checklist
Issue/User story
Fixes part of #1557
Steps to Reproduce
Existing issues
Design of the fix
Validation of the fix
Automated Tests
What documentation has been provided for this pull request