GetHistoryForKey to return correct data #375
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The 2.5 release used an updated protobuf js library; this has meant changes across the codebase to use this new library, subtly different API.. this function was sadly missed. Signed-off-by: Matthew B White <whitemat@uk.ibm.com>
mbwhite
force-pushed
the
rel2.5/getHistoryKey
branch
from
9100d47
to
3725b7e
Compare
Signed-off-by: Matthew B White <whitemat@uk.ibm.com>
mbwhite
force-pushed
the
rel2.5/getHistoryKey
branch
from
4236221
to
0caf430
Compare
|
@mergify backport main |
|
Sorry but I didn't understand the command. Please consult the commands documentation 📚. |
✅ Backports have been created
|
jt-nti
approved these changes
Jan 24, 2023
mergify bot
pushed a commit
that referenced
this pull request
Jan 24, 2023
* GetHistoryForKey to return correct data The 2.5 release used an updated protobuf js library; this has meant changes across the codebase to use this new library, subtly different API.. this function was sadly missed. Signed-off-by: Matthew B White <whitemat@uk.ibm.com> * Fix unit tests Signed-off-by: Matthew B White <whitemat@uk.ibm.com> Signed-off-by: Matthew B White <whitemat@uk.ibm.com> (cherry picked from commit 982edda)
mbwhite
added a commit
that referenced
this pull request
Jan 24, 2023
* GetHistoryForKey to return correct data The 2.5 release used an updated protobuf js library; this has meant changes across the codebase to use this new library, subtly different API.. this function was sadly missed. Signed-off-by: Matthew B White <whitemat@uk.ibm.com> * Fix unit tests Signed-off-by: Matthew B White <whitemat@uk.ibm.com> Signed-off-by: Matthew B White <whitemat@uk.ibm.com> (cherry picked from commit 982edda) Co-authored-by: Matthew B White <whitemat@uk.ibm.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The 2.5 release used an updated protobuf js library; this has meant changes across the codebase to use this new library, subtly different API.. this function was sadly missed.
resolves #374
Signed-off-by: Matthew B White whitemat@uk.ibm.com