Update fabric-protos-go dependency #208
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
bestbeforetoday
force-pushed
the
protos
branch
from
498ae80
to
03e2f42
Compare
bestbeforetoday
force-pushed
the
protos
branch
from
03e2f42
to
57a9c56
Compare
Codecov Report
@@ Coverage Diff @@
## main #208 +/- ##
=======================================
Coverage 76.09% 76.09%
=======================================
Files 193 193
Lines 14064 14064
=======================================
Hits 10702 10702
Misses 2393 2393
Partials 969 969
Continue to review full report at Codecov.
|
bestbeforetoday
force-pushed
the
protos
branch
from
57a9c56
to
d7518b2
Compare
This version of the Fabric protobuf Go bindings is functionally compatible with the previous one, but contains changes released in Fabric v2.4 and so makes this Go SDK able to coexist with the Fabric Gateway API for Go released alongside Fabric v2.4. Signed-off-by: Mark S. Lewis <mark_lewis@uk.ibm.com>
bestbeforetoday
force-pushed
the
protos
branch
from
d7518b2
to
1efcf43
Compare
|
PR build is failing purely because the existing tests do not touch enough of the code affected by protobuf import changes. No functional changes or additions have been made to the code. |
|
@troyronda Could you advise the best course of action for this change? |
troyronda
approved these changes
Jan 17, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This version of the Fabric protobuf Go bindings is functionally compatible with the previous one, but contains changes released in Fabric v2.4 and so makes this Go SDK able to coexist with the Fabric Gateway API for Go released alongside Fabric v2.4.
Note that, since the relocated protobufs are exposed in the public API of the SDK, this does represent a minor change to the public API.