Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add ExtractMSPIDsForApplicationOrgs util method to channelconfig #1363

Merged
merged 1 commit into from
Jun 3, 2020

Conversation

wenjianqiao
Copy link
Contributor

Signed-off-by: Wenjian Qiao wenjianq@gmail.com

Type of change

  • Improvement (improvement to code, performance, etc)

Description

Add a util method to extract MSPIDs for applications from a config block.

Additional details

This util method will be called by ledger to create checkpoint snapshots and remove per-channel databases when using state couchdb.

Related issues

https://jira.hyperledger.org/browse/FAB-17942
https://jira.hyperledger.org/browse/FAB-17787

Copy link
Contributor

@lindluni lindluni left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Couple nits on the logging statements

common/channelconfig/util.go Outdated Show resolved Hide resolved
common/channelconfig/util.go Outdated Show resolved Hide resolved
common/channelconfig/util.go Outdated Show resolved Hide resolved
@wenjianqiao wenjianqiao marked this pull request as ready for review June 2, 2020 21:07
@wenjianqiao wenjianqiao requested a review from a team as a code owner June 2, 2020 21:07
@wenjianqiao wenjianqiao force-pushed the fab17942a branch 2 times, most recently from 0e6edcf to 3447dbc Compare June 2, 2020 22:08
Add a util method to extract MSPIDs for applications from a config block.
For unit test, use a configblock json file to create the config block.

Signed-off-by: Wenjian Qiao <wenjianq@gmail.com>
@wenjianqiao
Copy link
Contributor Author

Hit gossip UT flake: https://jira.hyperledger.org/browse/FAB-17451

@wenjianqiao
Copy link
Contributor Author

/ci-run

@caod123 caod123 merged commit f8f6457 into hyperledger:master Jun 3, 2020
@wenjianqiao wenjianqiao deleted the fab17942a branch June 3, 2020 12:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants