add embed files to the package chaincode #4729
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Fedor Partanskiy <pfi79@mail.ru>
C0rWin
approved these changes
Mar 7, 2024
|
@Mergifyio backport release-2.5 |
✅ Backports have been created
|
mergify bot
pushed a commit
that referenced
this pull request
Mar 7, 2024
Signed-off-by: Fedor Partanskiy <pfi79@mail.ru> (cherry picked from commit 5ba69f6)
denyeart
pushed a commit
that referenced
this pull request
Mar 7, 2024
Signed-off-by: Fedor Partanskiy <pfi79@mail.ru> (cherry picked from commit 5ba69f6)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Recently pr failed tests and failed to update the
google.golang.org/protobufpackage.The reason is that we added go:embed to the https://github.com/protocolbuffers/protobuf-go/blob/master/internal/editiondefaults/defaults.go. When building the package we didn't copy file editions_defaults.binpb and the build of the chaincode ended with an error.
After accepting this pr, you can update the package again