[FAB-17462] Create signature for config update #669
Conversation
|
/ci-run |
Signed-off-by: Chongxin Luo <Chongxin.Luo@ibm.com> Signed-off-by: Will Lahti <wtlahti@us.ibm.com>
| var publicKey, privateKey []byte | ||
|
|
||
| func TestMain(m *testing.M) { | ||
| publicKey, privateKey = generatePublicAndPrivateKey() | ||
|
|
||
| os.Exit(m.Run()) | ||
| } | ||
|
|
There was a problem hiding this comment.
We don't use package level state. Call the function to generate one when you need it. Do it in the tests.
| } | ||
|
|
||
| // createNonce generates a nonce using the crypto/rand package. | ||
| func createNonce() ([]byte, error) { |
There was a problem hiding this comment.
So, createNonce creates a nonce; it calls getRandomNonce that explicitly creates a 24 byte long slice. That length seems awfully specific...
If we want a reusable function, we need to make it reusable by having proper parameterization. We should either fold getRandomNonce into createNonce or rename getRandomNonce to reflect that it's getting random data of a certain length and pass in that length.
| } | ||
|
|
||
| func TestECDSAPublicKeyImport(t *testing.T) { | ||
| t.Run("certificate does not contain valid ecdsa publicKey", func(t *testing.T) { |
There was a problem hiding this comment.
See comment above as well as for the ones below. If you want to annotate the test you can add the context to the matcher https://onsi.github.io/gomega/#annotating-assertions
t.Run is useful for sub-testing (table testing etc) and allows for finer grained control when trying to run a specific test from CLI. If there's only one test in the function you can still run that specific test via the CLI using the top level function name
|
fixes for additional requests has been applied in this PR: #687 |
Type of change
Description
This PR is part of an effort to create an easier way to create and update the channel configuration for fabric networks. This specific PR creates a signature for the provided configuration update.
Related issues
FAB-17467