[FAB-17466] Generate create channel transaction #686
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
stephyee
force-pushed
the
fab-17466
branch
3 times, most recently
from
68a6db0
to
905c272
Compare
DereckLuo
reviewed
Feb 17, 2020
pkg/config/config.go
Outdated
| // operation fails. | ||
| func MarshalOrPanic(pb proto.Message) []byte { | ||
| func protoMarshalOrPanic(pb proto.Message) []byte { | ||
| data, err := proto.Marshal(pb) |
There was a problem hiding this comment.
we might not want to panic at all in this package?
#669 (comment)
wlahti
reviewed
Feb 18, 2020
wlahti
reviewed
Feb 18, 2020
wlahti
previously approved these changes
Feb 19, 2020
Signed-off-by: Tiffany Harris <tiffany.harris@ibm.com> Signed-off-by: Danny Cao <dcao@us.ibm.com>
caod123
force-pushed
the
fab-17466
branch
2 times, most recently
from
2a15d4a
to
6086aa9
Compare
|
Fixed a couple other things I noticed in the tests (alongside a parallel fix for FAB-17515). This PR is now holding up 3-4 other PRs dependent on this being merged. Seeing as how this has already been thoroughly reviewed within the squad, we've talked to Matt already and he's agreed we can go ahead and merge this and he'll come back to this with any followup comments after he returns. @denyeart could you go ahead and merge this barring any comments you may have? |
|
Sure, looks like comments addressed, merging. |
denyeart
approved these changes
Feb 20, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Signed-off-by: Tiffany Harris tiffany.harris@ibm.com
Signed-off-by: Danny Cao dcao@us.ibm.com
Type of change
Description
Generates a channel create transaction using the a profile and msp config
Related issues
FAB-17466