Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

cmd tests implementations #286

Merged
merged 35 commits into from Feb 15, 2024
Merged

cmd tests implementations #286

merged 35 commits into from Feb 15, 2024

Conversation

Philip-21
Copy link
Contributor

This pr fixes for #7

nguyer and others added 3 commits January 11, 2024 09:06
@nguyer
Update dependencies and Go version
a1898bc 
Signed-off-by: Nicko Guyer <nicko.guyer@kaleido.io>
@nguyer
Update to Go 1.21
9871897 
Signed-off-by: Nicko Guyer <nicko.guyer@kaleido.io>
@Philip-21
cmd test implementations
27d2432 
Signed-off-by: Philip-21 <philipuzomaobiora@gmail.com>
Philip-21 and others added 23 commits January 20, 2024 23:03
@Philip-21
account cmd tests
213753e 
Signed-off-by: Philip-21 <philipuzomaobiora@gmail.com>
@Philip-21
account cmd tests
1d6fded 
Signed-off-by: Philip-21 <philipuzomaobiora@gmail.com>
@Philip-21
account cmd tests
88336be 
Signed-off-by: Philip-21 <philipuzomaobiora@gmail.com>
@Philip-21
info cmd tests
78813c9 
Signed-off-by: Philip-21 <philipuzomaobiora@gmail.com>
@nguyer
Fix unit tests and add to Makefile
bdeda39 
Signed-off-by: Nicko Guyer <nicko.guyer@kaleido.io>
@nguyer
Remove lint
a36b224 
Signed-off-by: Nicko Guyer <nicko.guyer@kaleido.io>
@nguyer
Apply firefly golangci rules
670bcf8 
Signed-off-by: Nicko Guyer <nicko.guyer@kaleido.io>
@nguyer
Merge branch 'dependencies' into fix-tests
70c0c6a 
Signed-off-by: Nicko Guyer <nicko.guyer@kaleido.io>
@nguyer
Merge branch 'main' into fix-tests
8c2a78a 
Signed-off-by: Nicko Guyer <nicko.guyer@kaleido.io>
@nguyer
Add go mod tidy to Makefile
4e9dd15 
Signed-off-by: Nicko Guyer <nicko.guyer@kaleido.io>
@nguyer
Fix unit test
8f78516 
Signed-off-by: Nicko Guyer <nicko.guyer@kaleido.io>
@Philip-21
Merge remote-tracking branch 'origin/main' into cmdtests
99ad4ba
@Philip-21
new tests
c0ad2ae 
Signed-off-by: Philip-21 <philipuzomaobiora@gmail.com>
@Philip-21
eth cmd tests
128d3b7 
Signed-off-by: Philip-21 <philipuzomaobiora@gmail.com>
@Philip-21
eth cmd tests
c6946cd 
Signed-off-by: Philip-21 <philipuzomaobiora@gmail.com>
@Philip-21
tezos tests
4dcceb0 
Signed-off-by: Philip-21 <philipuzomaobiora@gmail.com>
@Philip-21
eth tests
2a29589 
Signed-off-by: Philip-21 <philipuzomaobiora@gmail.com>
@Philip-21
eth tests
0080595 
Signed-off-by: Philip-21 <philipuzomaobiora@gmail.com>
@Philip-21
eth tests
4c08dc4 
Signed-off-by: Philip-21 <philipuzomaobiora@gmail.com>
@Philip-21
tezos tests
409b9b2 
Signed-off-by: Philip-21 <philipuzomaobiora@gmail.com>
@Philip-21
tezos tests
663c5c2 
Signed-off-by: Philip-21 <philipuzomaobiora@gmail.com>
@Philip-21
evm connect tests
13a31f4 
Signed-off-by: Philip-21 <philipuzomaobiora@gmail.com>
@Philip-21
eth connect tests
45862d3 
Signed-off-by: Philip-21 <philipuzomaobiora@gmail.com>
@Philip-21
Copy link
Contributor Author

@nguyer I have been able to create vast amount of unit tests here . This can be merged

nguyer
nguyer suggested changes Feb 13, 2024
View reviewed changes
Copy link
Contributor

@nguyer nguyer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is great. Thank you for adding so many tests! I think we should do two things before this could be merged.

  1. Can you merge the fix-tests branch into this one? Fix tests #288
    I fixed a number of issues with the existing tests in this branch, including making them run as a part of the CI workflow (using make). I want to make sure we have all tests passing before we merge.

  2. Can you make sure that none of the tests leave a modified git tree when they are done? Right now it looks like some of the tests write a file that is not cleaned up at the end of the test. You can refer to my branch/PR for how to use t.TempDir() in tests to solve this issue

@Philip-21
Copy link
Contributor Author

Philip-21 commented Feb 14, 2024 •
edited

This is great. Thank you for adding so many tests! I think we should do two things before this could be merged.

  1. Can you merge the fix-tests branch into this one? Fix tests #288
    I fixed a number of issues with the existing tests in this branch, including making them run as a part of the CI workflow (using make). I want to make sure we have all tests passing before we merge.
  2. Can you make sure that none of the tests leave a modified git tree when they are done? Right now it looks like some of the tests write a file that is not cleaned up at the end of the test. You can refer to my branch/PR for how to use t.TempDir() in tests to solve this issue

I will do all these

@Philip-21
Merge fix-tests branch from fixtests remote
875c779 
Signed-off-by: Philip-21 <philipuzomaobiora@gmail.com>
@Philip-21
tidying modules
c7e5a95 
Signed-off-by: Philip-21 <philipuzomaobiora@gmail.com>
@Philip-21
working on failed tests, removing testfiles
3eebaed 
Signed-off-by: Philip-21 <philipuzomaobiora@gmail.com>
@Philip-21
working on failed tests, removing testfiles
e971aac 
Signed-off-by: Philip-21 <philipuzomaobiora@gmail.com>
@Philip-21
blockchain signer tests
fc98ebb 
Signed-off-by: Philip-21 <philipuzomaobiora@gmail.com>
@Philip-21
using temDir() and removing testfiles
1cc11e9 
Signed-off-by: Philip-21 <philipuzomaobiora@gmail.com>
@Philip-21
fabric tests, tempDir() adjustments
89db167 
Signed-off-by: Philip-21 <philipuzomaobiora@gmail.com>
@Philip-21
cmdtest adjustments
b3e1818 
Signed-off-by: Philip-21 <philipuzomaobiora@gmail.com>
@Philip-21
asjustment and new signer test
c7061ab 
Signed-off-by: Philip-21 <philipuzomaobiora@gmail.com>
nguyer
nguyer approved these changes Feb 15, 2024
View reviewed changes
Copy link
Contributor

@nguyer nguyer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Wonderful! Thank you so much for contributing this!

@nguyer nguyer merged commit f36db31 into hyperledger:main Feb 15, 2024
12 checks passed
@Philip-21
Copy link
Contributor Author

Wonderful! Thank you so much for contributing this!

My pleasure

@Philip-21 Philip-21 deleted the cmdtests branch February 15, 2024 18:37
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@nguyer nguyer nguyer approved these changes

@awrichar awrichar Awaiting requested review from awrichar

@peterbroadhurst peterbroadhurst Awaiting requested review from peterbroadhurst

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@Philip-21 @nguyer