Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix tests #288

Merged
merged 9 commits into from Feb 15, 2024
Merged

Fix tests #288

merged 9 commits into from Feb 15, 2024

Conversation

nguyer
Copy link
Contributor

@nguyer nguyer commented Jan 24, 2024 •
edited

This PR resolves #287

  • Fixes failing unit tests
  • Prevents tests from creating new files tracked by git
  • Adds test and lint commands to make all
  • Adds golangci config from main firefly repo
  • Fixes all linter errors (with several exceptions added)

@nguyer
Update dependencies and Go version
a1898bc 
Signed-off-by: Nicko Guyer <nicko.guyer@kaleido.io>
@nguyer
Update to Go 1.21
9871897 
Signed-off-by: Nicko Guyer <nicko.guyer@kaleido.io>
@nguyer
Fix unit tests and add to Makefile
bdeda39 
Signed-off-by: Nicko Guyer <nicko.guyer@kaleido.io>
@nguyer
Remove lint
a36b224 
Signed-off-by: Nicko Guyer <nicko.guyer@kaleido.io>
@nguyer
Apply firefly golangci rules
670bcf8 
Signed-off-by: Nicko Guyer <nicko.guyer@kaleido.io>
@nguyer
Merge branch 'dependencies' into fix-tests
70c0c6a 
Signed-off-by: Nicko Guyer <nicko.guyer@kaleido.io>
@nguyer nguyer mentioned this pull request Jan 24, 2024
Closed
@nguyer
Merge branch 'main' into fix-tests
8c2a78a 
Signed-off-by: Nicko Guyer <nicko.guyer@kaleido.io>
@nguyer
Add go mod tidy to Makefile
4e9dd15 
Signed-off-by: Nicko Guyer <nicko.guyer@kaleido.io>
@nguyer
Fix unit test
8f78516 
Signed-off-by: Nicko Guyer <nicko.guyer@kaleido.io>
@nguyer nguyer mentioned this pull request Feb 13, 2024
Merged
@nguyer nguyer merged commit 875c779 into hyperledger:main Feb 15, 2024
12 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@awrichar awrichar Awaiting requested review from awrichar

@peterbroadhurst peterbroadhurst Awaiting requested review from peterbroadhurst

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Failing Unit Tests
1 participant
@nguyer