Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use defer to unlock mutex #89

Merged
merged 1 commit into from
Jun 2, 2022

Conversation

jimthematrix
Copy link
Contributor

No description provided.

Signed-off-by: Jim Zhang <jim.zhang@kaleido.io>
@codecov-commenter
Copy link

Codecov Report

Merging #89 (22d8b9f) into main (b8908f5) will increase coverage by 2.36%.
The diff coverage is 98.00%.

@@            Coverage Diff             @@
##             main      #89      +/-   ##
==========================================
+ Coverage   65.93%   68.30%   +2.36%     
==========================================
  Files          47       47              
  Lines        4439     4483      +44     
==========================================
+ Hits         2927     3062     +135     
+ Misses       1330     1229     -101     
- Partials      182      192      +10     
Impacted Files Coverage Δ
internal/fabric/client/api.go 0.00% <ø> (ø)
internal/fabric/client/identity.go 70.83% <90.90%> (+41.82%) ⬆️
internal/fabric/client/client_ccp.go 41.22% <100.00%> (+4.43%) ⬆️
...nternal/fabric/client/client_gateway_clientside.go 40.76% <100.00%> (+5.47%) ⬆️
internal/fabric/client/eventsubscriber.go 49.23% <100.00%> (+7.12%) ⬆️
internal/fabric/client/ledger.go 32.89% <100.00%> (+7.89%) ⬆️
internal/events/eventstream.go 91.96% <0.00%> (-0.90%) ⬇️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 202008b...22d8b9f. Read the comment docs.

Copy link
Contributor

@peterbroadhurst peterbroadhurst left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

@peterbroadhurst peterbroadhurst merged commit 4f6ff0c into hyperledger:main Jun 2, 2022
@peterbroadhurst peterbroadhurst deleted the mutex-unlock branch June 2, 2022 20:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants