Process BatchTransfer events #45
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This allows more flexibility in transformation, such as emitting multiple events based on a single input event. Signed-off-by: Andrew Richardson <andrew.richardson@kaleido.io>
Although this is not directly triggered by the connector in any case, we still need to listen for it in order to maintain a correct picture of all transfers. Treat it as a series of TransferSingle events. Signed-off-by: Andrew Richardson <andrew.richardson@kaleido.io>
Signed-off-by: Andrew Richardson <andrew.richardson@kaleido.io>
Clients need a key that is guaranteed to be unique in order to avoid double-processing of events. Previously we were using transactionHash, but this will not be unique in many cases with loops that emit multiple events - for instance: - Calling mintNonFungible triggers a loop in Solidity - Calling safeBatchTransferFrom triggers a loop in the tokens service Therefore we'll build a new id based on block number, transaction index, log index, and an optional application-specified index. This will reliably be unique for every event. Signed-off-by: Andrew Richardson <andrew.richardson@kaleido.io>
nguyer
reviewed
Nov 24, 2021
| } | ||
| }); | ||
| } catch (err) { | ||
| // do nothing |
There was a problem hiding this comment.
Should we at least log something here?
There was a problem hiding this comment.
Yea, probably a good idea
Signed-off-by: Andrew Richardson <andrew.richardson@kaleido.io>
nguyer
approved these changes
Nov 24, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Also add a new "id" parameter to every transfer event, which can be used for de-duplication.