Issue85 metadata api #87
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Chengxuan Xing <chengxuan.xing@kaleido.io>
Signed-off-by: Chengxuan Xing <chengxuan.xing@kaleido.io>
Chengxuan
requested review from
awrichar,
peterbroadhurst and
nguyer
as code owners
awrichar
reviewed
Aug 12, 2022
There was a problem hiding this comment.
Reviewing this now - two style/formatting notes:
- Can you run
npm run format? - Not sure why the entire samples/solidity/package-lock.json file was rewritten - looks like a bunch of whitespace changed for some reason. Would be nice to not overwrite it if it's not needed.
awrichar
reviewed
Aug 12, 2022
awrichar
requested changes
Aug 12, 2022
Signed-off-by: Chengxuan Xing <chengxuan.xing@kaleido.io>
Signed-off-by: Chengxuan Xing <chengxuan.xing@kaleido.io>
Signed-off-by: Chengxuan Xing <chengxuan.xing@kaleido.io>
|
@awrichar thank you for the comments. I've addressed them. Ready to be reviewed again. |
Signed-off-by: Chengxuan Xing <chengxuan.xing@kaleido.io>
Closed
awrichar
reviewed
Aug 15, 2022
awrichar
approved these changes
Aug 15, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Resolves #85