-
Notifications
You must be signed in to change notification settings - Fork 204
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add helpers at /apis/{apiName}/listeners/{eventPath} #696
Conversation
Signed-off-by: Andrew Richardson <andrew.richardson@kaleido.io>
Signed-off-by: Andrew Richardson <andrew.richardson@kaleido.io>
Signed-off-by: Andrew Richardson <andrew.richardson@kaleido.io>
Signed-off-by: Andrew Richardson <andrew.richardson@kaleido.io>
These are used only for reporting and filtering on Prometheus. Signed-off-by: Andrew Richardson <andrew.richardson@kaleido.io>
Signed-off-by: Andrew Richardson <andrew.richardson@kaleido.io>
56460f4
to
4dfe60d
Compare
GET and POST to list matching listeners or create new ones. Signed-off-by: Andrew Richardson <andrew.richardson@kaleido.io>
The same purpose is served by the root /contract/invoke and /contracts/query endpoints, when passing an interface ID. Also split "methodPath" out as a separate parameter, so it's clear that you must specify either it or "method". Signed-off-by: Andrew Richardson <andrew.richardson@kaleido.io>
Codecov Report
@@ Coverage Diff @@
## main #696 +/- ##
==========================================
Coverage 100.00% 100.00%
==========================================
Files 323 323
Lines 19770 19874 +104
==========================================
+ Hits 19770 19874 +104
Continue to review full report at Codecov.
|
Signed-off-by: Andrew Richardson <andrew.richardson@kaleido.io>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Few questions from me here @awrichar
Also, in the header comment of the PR (and soon in API descriptions fyi @nguyer ) would be good to note the |
Signed-off-by: Andrew Richardson <andrew.richardson@kaleido.io>
Signed-off-by: Andrew Richardson <andrew.richardson@kaleido.io>
Signed-off-by: Andrew Richardson <andrew.richardson@kaleido.io>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
👍
This includes the commit from #693.
Add helper URLs:
Also makes
topic
a required field for contract listeners, and enforces uniqueness of listeners across these 2 dimensions:Violating either uniqueness constraint when attempting to create a listener will result in HTTP 409, so applications can rely on this behavior to perform "create this listener if it does not already exist". Note that
name
is still optional, and a unique one will be assigned at creation time if none is specified.