Allow namespace to be omitted from URLs #792
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
awrichar
requested review from
peterbroadhurst,
nguyer and
nickgaski
as code owners
For all namespaced URLs, add two routes - one beginning with "namespace/{ns}/"
that continues to function as before, and another without the prefix that
simply uses the default namespace. The routes are grouped into different
categories on the Swagger UI page.
This allows using shorter URLs in the common case that you want to interact
with the default namespace.
Signed-off-by: Andrew Richardson <andrew.richardson@kaleido.io>
peterbroadhurst
approved these changes
May 5, 2022
This was referenced May 6, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Proposal to tweak our route generation so that namespaced routes will actually generate two versions of the route:
/datathat implies use of the default namespace/namespaces/{ns}/datathat allows you to specify the namespaceTo reduce clutter on the Swagger UI page, routes will also now be grouped into 3 category buckets. I'm open to names for these categories, but I've proposed "Global", "Default Namespace", and "Non-Default Namespace".
The main functional changes are in
internal/apiserver/routes.go.