-
Notifications
You must be signed in to change notification settings - Fork 14
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Allow "diddocContent" in ATTRIB on older networks. #77
Allow "diddocContent" in ATTRIB on older networks. #77
Conversation
Signed-off-by: Markus Sabadello <markus@danubetech.com>
3b4088c
to
6f45ce9
Compare
I think it would be beneficial for some clarity on how implementations should behave in the presence of both an attrib Otherwise, I think this is likely a prudent way to handle slower than ideal rollout of did:indy. Thoughts @swcurran? |
I’m happy to add this and promote that this should be added to all resolver implementations. It would be useful to have an example in of an ATTRIB based DID Doc Content entry — e.g. the JSON for a given DIDDoc and the ATTRIB raw value. What do you think? Agree with @dbluhm that there should be a definition of what happens if both a DID with Thanks @peacekeeper ! |
Yes this was my idea as well, to be consistent with what we are saying about I agree with @dbluhm that some more details should be added to this PR, i'll work on that. |
c8445db
to
83956c2
Compare
@dbluhm @swcurran I updated this PR to move this new content into its own section. I tried to explain better how clients should behave, based on your feedback, which was how I intended it to be anyway. I also added an example. Maybe you could re-review? Let me know if anything is still unclear or could be improved. |
83956c2
to
b7cd063
Compare
|
||
::: example Example `raw` value of an "ATTRIB `diddocContent`" | ||
```json | ||
{ |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I was thinking that the example had to be like this — e.g. that the JSON had to be stringified. That’s what I meant about an example. Same as this example ATTRIB on TestNet — https://indyscan.io/tx/SOVRIN_STAGINGNET/domain/339997
"{ \"diddocContent\": { \"@context\": [ \"https://www.w3.org/ns/did/v1\", \"https://identity.foundation/didcomm-messaging/service-endpoint/v1\" ], \"service\": [{ \"id\": \"did:indy:sovrin:123456#did-communication\", \"type\": \"did-communication\", \"priority\": 0, \"serviceEndpoint\": \"https://example.com\", \"recipientKeys\": [\"#verkey\"], \"routingKeys\": [] }] } }"
Looks good — although see my comment above. The submission is missing DCO — please fix that. DCO - Developer Certificate of Origin - https://github.com/apps/dco. See “Details” link above, beside failed test. |
Signed-off-by: Markus Sabadello <markus@danubetech.com>
b7cd063
to
ade379e
Compare
Signed-off-by: Markus Sabadello <markus@danubetech.com>
Could we merge this, or are there any concerns? |
Sorry for the delay — just lost sight of the issue. |
Fixes #71.
I know this adds some complexity, but I believe there are advantages in allowing "diddocContent" in an ATTRIB for those older networks that don't support "diddocContent" in a NYM yet.