Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Initial implementation of plugin architecture. #26

Merged
merged 6 commits into from
Mar 22, 2021

Conversation

KoleBarnes
Copy link
Contributor

Including documentation.

Signed-off-by: KoleBarnes <kbarnes261@gmail.com>
Signed-off-by: KoleBarnes <kbarnes261@gmail.com>
Signed-off-by: KoleBarnes <kbarnes261@gmail.com>
Signed-off-by: KoleBarnes <kbarnes261@gmail.com>
Signed-off-by: KoleBarnes <kbarnes261@gmail.com>
@WadeBarnes
Copy link
Member

@lohanspies, @lynnbendixsen

@lohanspies
Copy link

@lohanspies, @lynnbendixsen

Brilliant! Thank you @WadeBarnes and @KoleBarnes. This is a massive improvement.

@WadeBarnes
Copy link
Member

WadeBarnes commented Mar 17, 2021

A note for @swcurran. This is the initial framework. The additional automated node monitoring plugin(s) that are in development will be added once this is merged.

@WadeBarnes
Copy link
Member

@lohanspies, @lynnbendixsen

Brilliant! Thank you @WadeBarnes and @KoleBarnes. This is a massive improvement.

It's all @KoleBarnes, I'm just providing support and a little guidance.

Copy link
Member

@swcurran swcurran left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!! Nice work. I've not had a chance to run these, so am not marking approved yet (although others can), but I really like this approach. Even better than the bash pipeline way :-)

Signed-off-by: Wade Barnes <wade.barnes@shaw.ca>
Copy link
Member

@WadeBarnes WadeBarnes left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I've been using this heavily over the last few days while troubleshooting a few nodes on Sorin StagingNet. The only issue I discovered was one that existed in my original code.

@WadeBarnes WadeBarnes merged commit 2c7b4a1 into hyperledger:master Mar 22, 2021
@KoleBarnes KoleBarnes deleted the feature/plugin-architecture branch March 23, 2021 22:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants