Fix restart_indy_node under supervisord #1585
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ervisord, we must kill the process. Restarting indy_node_control from a script started by indy_node_control itself causes a hang. Signed-off-by: Keith Smith <bksmith@us.ibm.com>
smithbk
requested review from
lampkin-diet,
ashcherbakov,
skhoroshavin and
Toktar
as code owners
|
Can one of the admins verify this patch? |
|
(ci) test this please |
ashcherbakov
approved these changes
Mar 10, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
After the indy_node_control process downloads a new version of software, it invokes /usr/local/bin/restart_indy_node which then invoked
supervisorctl restart indy-node-control. Unfortunately this command is not atomic and is equivalent tosupervisorctl stop indy-node-controlfollowed bysupervisorctl start indy-node-control, which results in NOT restarting indy-node-control because it has just stopped itself.The fix is for indy-node-control to simply commit suicide so that supervisord will automatically restart the process; that is, from a supervisorctl perspective, we do not change the state of the indy-node-control service.
Signed-off-by: Keith Smith bksmith@us.ibm.com