Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update CODEOWNERS #1664

Merged
merged 1 commit into from
Mar 9, 2021
Merged

Update CODEOWNERS #1664

merged 1 commit into from
Mar 9, 2021

Conversation

askolesov
Copy link
Member

WadeBarnes
WadeBarnes previously approved these changes Feb 26, 2021
Copy link
Member

@ryjones ryjones left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

CODEOWNERS Outdated
@@ -1,5 +1,5 @@
# indy-admin
* @esplinr @dhh1128 @nage
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

  • @hyperledger/indy-admin

CODEOWNERS Outdated Show resolved Hide resolved
brentzundel
brentzundel previously approved these changes Feb 27, 2021
ryjones
ryjones previously approved these changes Feb 27, 2021
@WadeBarnes
Copy link
Member

I like @ryjones's recommendation of listing GitHub groups in the file over explicitly listing users in the file. It would make it far easier to maintain the membership.

Use groups

Signed-off-by: Alexander Kolesov <alexander.kolesov@evernym.com>
Signed-off-by: Ry Jones <ry@linux.com>
@ryjones ryjones requested review from brentzundel, WadeBarnes and ryjones and removed request for ryjones February 27, 2021 18:20
@ryjones ryjones enabled auto-merge (rebase) February 27, 2021 18:28
@brentzundel
Copy link
Member

I like the use of groups, but am concerned that now the same set of folks would be maintaining all of the Indy repos. Historically, the ledger code and the sdk code have been quite different and been maintained by different sets of engineers.
Not a blocking concern unless it is more widely shared, but I wanted to mention it.

@ryjones
Copy link
Member

ryjones commented Mar 1, 2021

I like the use of groups, but am concerned that now the same set of folks would be maintaining all of the Indy repos. Historically, the ledger code and the sdk code have been quite different and been maintained by different sets of engineers.
Not a blocking concern unless it is more widely shared, but I wanted to mention it.

@brentzundel I agree, in general. My hope is this PR is the first step to a broader process.

See discussion here: (feel free to join in!)

@ryjones ryjones merged commit 50d7af0 into master Mar 9, 2021
@ryjones ryjones deleted the codeowners-update branch March 9, 2021 12:18
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

5 participants