-
Notifications
You must be signed in to change notification settings - Fork 650
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Update CODEOWNERS #1664
Update CODEOWNERS #1664
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Please use groups - example: https://github.com/hyperledger/fabric/blob/master/CODEOWNERS
CODEOWNERS
Outdated
@@ -1,5 +1,5 @@ | |||
# indy-admin | |||
* @esplinr @dhh1128 @nage |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
- @hyperledger/indy-admin
I like @ryjones's recommendation of listing GitHub groups in the file over explicitly listing users in the file. It would make it far easier to maintain the membership. |
226238d
95bdb47
to
226238d
Compare
Use groups Signed-off-by: Alexander Kolesov <alexander.kolesov@evernym.com> Signed-off-by: Ry Jones <ry@linux.com>
226238d
to
781285e
Compare
I like the use of groups, but am concerned that now the same set of folks would be maintaining all of the Indy repos. Historically, the ledger code and the sdk code have been quite different and been maintained by different sets of engineers. |
@brentzundel I agree, in general. My hope is this PR is the first step to a broader process. See discussion here: (feel free to join in!) |
Updated codeownrs as proposed by @esplinr:
https://chat.hyperledger.org/channel/indy-contributors?msg=dNQ2CqY6PhRohpyDE