Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update CODEOWNERS #1518

Merged
merged 1 commit into from
Mar 9, 2021
Merged

Update CODEOWNERS #1518

merged 1 commit into from
Mar 9, 2021

Conversation

askolesov
Copy link
Member

WadeBarnes
WadeBarnes previously approved these changes Feb 26, 2021
View reviewed changes
ryjones
ryjones previously requested changes Feb 26, 2021
View reviewed changes
Copy link
Member

@ryjones ryjones left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please use groups - example: https://github.com/hyperledger/fabric/blob/master/CODEOWNERS

@WadeBarnes
Copy link
Member

I agree with @ryjones. More examples were provided over here; hyperledger/indy-node#1664

@askolesov @ryjones
Update CODEOWNERS
8192bbb 
Use groups

Signed-off-by: Alexander Kolesov <alexander.kolesov@evernym.com>
Signed-off-by: Ry Jones <ry@linux.com>
@ryjones ryjones requested review from ryjones and WadeBarnes and removed request for ryjones February 27, 2021 18:26
@ryjones ryjones enabled auto-merge (rebase) February 27, 2021 18:27
@ryjones ryjones dismissed their stale review February 27, 2021 18:28

time has moved on

@ryjones ryjones requested review from ryjones and removed request for ryjones February 27, 2021 18:28
@Toktar
Copy link
Contributor

Toktar commented Mar 9, 2021

(ci) test this please

@ryjones ryjones merged commit 29b62bc into master Mar 9, 2021
@ryjones ryjones deleted the codeowners-update branch March 9, 2021 13:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@WadeBarnes WadeBarnes WadeBarnes approved these changes

@Toktar Toktar Toktar approved these changes

@ryjones ryjones ryjones left review comments

@lampkin-diet lampkin-diet Awaiting requested review from lampkin-diet

@ashcherbakov ashcherbakov Awaiting requested review from ashcherbakov

@skhoroshavin skhoroshavin Awaiting requested review from skhoroshavin

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
4 participants
@askolesov @WadeBarnes @Toktar @ryjones