-
Notifications
You must be signed in to change notification settings - Fork 655
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Upgrade Ubuntu 20.04 #1667
Upgrade Ubuntu 20.04 #1667
Conversation
Signed-off-by: Ryan Marsh <ryan.marsh44@gmail.com>
Signed-off-by: Ryan Marsh <ryan.marsh44@gmail.com>
…20.04-upgrade Signed-off-by: Ryan Marsh <ryan.marsh44@gmail.com> Sign-off-executed-by: toktar <renata.toktar@evernym.com> Approved-at: behalf
Signed-off-by: Ryan Marsh <ryan.marsh44@gmail.com>
Signed-off-by: Ryan Marsh <ryan.marsh44@gmail.com>
Signed-off-by: Ryan Marsh <ryan.marsh44@gmail.com>
Signed-off-by: Ryan Marsh <ryan.marsh44@gmail.com>
Signed-off-by: Ryan Marsh <ryan.marsh44@gmail.com>
Signed-off-by: Ryan Marsh <ryan.marsh44@gmail.com>
Signed-off-by: Ryan Marsh <ryan.marsh44@gmail.com>
Signed-off-by: Ryan Marsh <ryan.marsh44@gmail.com>
Signed-off-by: Ryan Marsh <ryan.marsh44@gmail.com>
Signed-off-by: Ryan Marsh <ryan.marsh44@gmail.com>
Signed-off-by: Anton Denishchenko <anton.denishchenko@evernym.com>
Can one of the admins verify this patch? |
(ci) test this please |
@adenishchenko, What is the relation of this PR to the one @ryMarsh44 started here; WIP: Ubuntu 20.04 upgrade? |
@adenishchenko, Please edit the PR and target the |
@adenishchenko, Also if this PR is still a work in progress, please edit the PR and change it to a Draft PR until it is ready for final review. |
@WadeBarnes |
@ryMarsh44, @Toktar, @adenishchenko, What is the relationship between this PR and #1652? Can #1652 be closed in favor of this PR? |
@ryMarsh44, @Toktar, @adenishchenko, @udosson, If I understand correctly, based on the Indy Contributors call today, this PR can be taken out of WIP status. Is that correct? |
DCO Sign-off is missing from this commit; 9959164 |
@ryMarsh44, @Toktar, @adenishchenko, @udosson, @askolesov, There are no GHA workflows in this PR. Is this PR still relying on the Jenkins pipelines for running it's tests? What needs to be done to integrate the GHA workflows into the 20.04 upgrade work? |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
See comments
|
Yes, this needs to be fixed sooner than later. |
Seems that it's ready now. @WadeBarnes Could you review it one more time, please? |
Hello @WadeBarnes . Could you review this PR? |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
One item that needs to be addressed.
sudo cp /usr/lib/ursa/libursa.* /usr/lib/ | ||
# Should be done in python env | ||
pip install -U \ | ||
Pygments==2.2.0 \ |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This needs to be upgraded.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@WadeBarnes I totally agree with you, we need to update Pygments version. But Indy Node does not have a pinned dependency on Pygments package. And this file is just a set of recommendations for a virtual machine, relevant at the moment.
Thus, I propose not to block this PR and merge it, since Indy Node has nothing to do with Pygments package. Only after updating the package in Plenum does it make sense to update or delete this doc.
@Toktar, It looks like the code owner's file has not been updated on this branch yet. So you'll have to approve and merge. |
No description provided.