Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Upgrade Ubuntu 20.04 #1667

Merged
merged 16 commits into from
Apr 22, 2021
Merged

Upgrade Ubuntu 20.04 #1667

merged 16 commits into from
Apr 22, 2021

Conversation

adenishchenko
Copy link
Contributor

No description provided.

rytmarsh and others added 16 commits February 9, 2021 17:38
@rytmarsh
update libraries v1
e4033ef 
Signed-off-by: Ryan Marsh <ryan.marsh44@gmail.com>
@rytmarsh
collections.abc and module for tests
df7b41f 
Signed-off-by: Ryan Marsh <ryan.marsh44@gmail.com>
@rytmarsh
Merge remote-tracking branch 'ryan/ubuntu-20.04-upgrade' into ubuntu-…
a520884 
…20.04-upgrade

Signed-off-by: Ryan Marsh <ryan.marsh44@gmail.com>
Sign-off-executed-by: toktar <renata.toktar@evernym.com>
Approved-at: behalf
@rytmarsh
fixes pool_restart tests
f2253f1 
Signed-off-by: Ryan Marsh <ryan.marsh44@gmail.com>
@rytmarsh
upgrades deps and pytest features
75c12d9 
Signed-off-by: Ryan Marsh <ryan.marsh44@gmail.com>
@rytmarsh
another broken test
2b600ee 
Signed-off-by: Ryan Marsh <ryan.marsh44@gmail.com>
@rytmarsh
:
8a5ed3e 
Signed-off-by: Ryan Marsh <ryan.marsh44@gmail.com>
Sign-off-executed-by: toktar <renata.toktar@evernym.com>
Approved-at: behalf
@rytmarsh
adds failing tests to upgrade
4bb8043 
Signed-off-by: Ryan Marsh <ryan.marsh44@gmail.com>
@rytmarsh
.
93c89e9 
Signed-off-by: Ryan Marsh <ryan.marsh44@gmail.com>
@rytmarsh
changes get_marker() to get_closest_marker()
45d2b74 
Signed-off-by: Ryan Marsh <ryan.marsh44@gmail.com>
@rytmarsh
fixes multiple broken tests around newer pytest version
8462ec8 
Signed-off-by: Ryan Marsh <ryan.marsh44@gmail.com>
@rytmarsh
updates setup.py with newer python package versions
58c67a6 
Signed-off-by: Ryan Marsh <ryan.marsh44@gmail.com>
@rytmarsh
fixes broken fixture
33a9a21 
Signed-off-by: Ryan Marsh <ryan.marsh44@gmail.com>
@rytmarsh
updates failing test list
3087d29 
Signed-off-by: Ryan Marsh <ryan.marsh44@gmail.com>
@rytmarsh
fixes failing tests by looking 4 minutes in the past with journalctl
cb3e790 
Signed-off-by: Ryan Marsh <ryan.marsh44@gmail.com>
@adenishchenko
Delete useless test
1cd98b5 
Signed-off-by: Anton Denishchenko <anton.denishchenko@evernym.com>
@sovbot
Copy link

sovbot commented Mar 5, 2021

Can one of the admins verify this patch?

@WadeBarnes
Copy link
Member

(ci) test this please

@WadeBarnes
Copy link
Member

@adenishchenko, What is the relation of this PR to the one @ryMarsh44 started here; WIP: Ubuntu 20.04 upgrade?

@WadeBarnes
Copy link
Member

@adenishchenko, Please edit the PR and target the ubuntu-20.04-upgrade branch as the destination.

@WadeBarnes
Copy link
Member

@adenishchenko, Also if this PR is still a work in progress, please edit the PR and change it to a Draft PR until it is ready for final review.

@adenishchenko adenishchenko changed the base branch from master to ubuntu-20.04-upgrade March 9, 2021 09:42
@adenishchenko
Copy link
Contributor Author

adenishchenko commented Mar 9, 2021 •
edited
Loading

@WadeBarnes
Thank you for notices!
We are waiting for CD/CI Ubuntu 20.04 for indy-node now. I'll check a progress.

@WadeBarnes WadeBarnes mentioned this pull request Mar 30, 2021
Closed
@WadeBarnes
Copy link
Member

@ryMarsh44, @Toktar, @adenishchenko, What is the relationship between this PR and #1652? Can #1652 be closed in favor of this PR?

@WadeBarnes
Copy link
Member

@ryMarsh44, @Toktar, @adenishchenko, @udosson, If I understand correctly, based on the Indy Contributors call today, this PR can be taken out of WIP status. Is that correct?

@WadeBarnes
Copy link
Member

DCO Sign-off is missing from this commit; 9959164

@WadeBarnes
Copy link
Member

@ryMarsh44, @Toktar, @adenishchenko, @udosson, @askolesov, There are no GHA workflows in this PR. Is this PR still relying on the Jenkins pipelines for running it's tests? What needs to be done to integrate the GHA workflows into the 20.04 upgrade work?

WadeBarnes
WadeBarnes requested changes Mar 30, 2021
View reviewed changes
Copy link
Member

@WadeBarnes WadeBarnes left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

See comments

@askolesov
Copy link
Member

@WadeBarnes

  • PR duplicates: this is the main PR with upgrade work, WIP: Ubuntu 20.04 upgrade #1652 can be closed I think.
  • WIP status: yes, it can be taken out of it.
  • CI: this PR doesn't rely on Jenkins because Jenkins is only for 16.04. We definitely need to merge CI/CD work for Ubuntu 20.04 here, but I don't see a PR. (Sorry for my confusing PR, I've just closed it)
  • Signature: I think it's better to fix it right before merge.

@adenishchenko adenishchenko changed the title Upgrade Ubuntu 20.04 WIP Upgrade Ubuntu 20.04 Mar 31, 2021
@WadeBarnes WadeBarnes marked this pull request as draft March 31, 2021 13:50
@WadeBarnes
Copy link
Member

@WadeBarnes

  • Signature: I think it's better to fix it right before merge.

Yes, this needs to be fixed sooner than later.

@askolesov
Copy link
Member

Seems that it's ready now. @WadeBarnes Could you review it one more time, please?

@askolesov askolesov marked this pull request as ready for review April 20, 2021 09:30
@adenishchenko adenishchenko changed the title WIP Upgrade Ubuntu 20.04 Upgrade Ubuntu 20.04 Apr 20, 2021
@adenishchenko
Copy link
Contributor Author

Hello @WadeBarnes . Could you review this PR?

@Toktar Toktar mentioned this pull request Apr 20, 2021
Closed
WadeBarnes
WadeBarnes requested changes Apr 21, 2021
View reviewed changes
Copy link
Member

@WadeBarnes WadeBarnes left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

One item that needs to be addressed.

dev-setup/ubuntu/ubuntu-2004/SetupVMTest.txt
sudo cp /usr/lib/ursa/libursa.* /usr/lib/
# Should be done in python env
pip install -U \
Pygments==2.2.0 \
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This needs to be upgraded.

Copy link
Contributor

@Toktar Toktar Apr 21, 2021 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@WadeBarnes I totally agree with you, we need to update Pygments version. But Indy Node does not have a pinned dependency on Pygments package. And this file is just a set of recommendations for a virtual machine, relevant at the moment.
Thus, I propose not to block this PR and merge it, since Indy Node has nothing to do with Pygments package. Only after updating the package in Plenum does it make sense to update or delete this doc.

@WadeBarnes
Copy link
Member

@Toktar, It looks like the code owner's file has not been updated on this branch yet. So you'll have to approve and merge.

@Toktar Toktar merged commit 339f278 into hyperledger:ubuntu-20.04-upgrade Apr 22, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@WadeBarnes WadeBarnes WadeBarnes approved these changes

@Toktar Toktar Toktar approved these changes

@lampkin-diet lampkin-diet Awaiting requested review from lampkin-diet

@ashcherbakov ashcherbakov Awaiting requested review from ashcherbakov

@skhoroshavin skhoroshavin Awaiting requested review from skhoroshavin

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
6 participants
@adenishchenko @sovbot @WadeBarnes @askolesov @Toktar @rytmarsh