INDY-2223: ViewChange message serialization #1338
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Sergey Khoroshavin <sergey.khoroshavin@dsr-corporation.com>
Signed-off-by: Sergey Khoroshavin <sergey.khoroshavin@dsr-corporation.com>
Signed-off-by: Sergey Khoroshavin <sergey.khoroshavin@dsr-corporation.com>
Signed-off-by: toktar <renata.toktar@dsr-corporation.com>
Toktar
requested review from
lampkin-diet,
ashcherbakov and
skhoroshavin
as code owners
Signed-off-by: Sergey Khoroshavin <sergey.khoroshavin@dsr-corporation.com>
Signed-off-by: Sergey Khoroshavin <sergey.khoroshavin@dsr-corporation.com>
Signed-off-by: toktar <renata.toktar@dsr-corporation.com>
|
This pull request introduces 3 alerts when merging fccfaf8 into 018526a - view on LGTM.com new alerts:
|
Signed-off-by: toktar <renata.toktar@dsr-corporation.com>
|
This pull request introduces 3 alerts when merging 3fdf4d9 into 018526a - view on LGTM.com new alerts:
|
Signed-off-by: toktar <renata.toktar@dsr-corporation.com>
|
This pull request introduces 4 alerts when merging 621e6b7 into 018526a - view on LGTM.com new alerts:
|
|
test this please |
Signed-off-by: toktar <renata.toktar@dsr-corporation.com>
Signed-off-by: toktar <renata.toktar@dsr-corporation.com>
…nto task-2178-view-change-requestor
Toktar
changed the title
…ndy-plenum into task-2178-view-change-requestor
|
This pull request introduces 4 alerts when merging 987e118 into 018526a - view on LGTM.com new alerts:
|
Signed-off-by: toktar <renata.toktar@dsr-corporation.com>
|
This pull request introduces 4 alerts when merging fac6419 into f68d274 - view on LGTM.com new alerts:
|
skhoroshavin
previously approved these changes
Sep 19, 2019
| (NonNegativeNumberField().validate, pp_view_no), | ||
| (NonNegativeNumberField().validate, pp_seq_no), | ||
| (NonEmptyStringField().validate, pp_digest)): | ||
| bid = BatchID(*val) |
There was a problem hiding this comment.
- This line can throw, and as far as I understand caller of
_specific_validationdoesn't expect exceptions. If so it needs to be fixed to just return an error (either by wrapping in try/except or adding additional checks) - Serialized BatchID should be dictionary, not list.
|
|
||
| # An example when `view_no` != `pp_view_no`, is when view change didn't finish at first round | ||
| # (next primary is unavailable for example) | ||
| from typing import NamedTuple |
There was a problem hiding this comment.
I'd rather move import to the top, and keep comments attached to BatchID definition
| serialized_msg = Batched().prepForSending(msg) | ||
| serialized_msg = ZStack.serializeMsg(serialized_msg) | ||
| new_msg = node_message_factory.get_instance(**ZStack.deserializeMsg(serialized_msg)) | ||
| if not isinstance(msg, MessageRep): |
There was a problem hiding this comment.
Why exclude MessageRep here?
Signed-off-by: Sergey Khoroshavin <sergey.khoroshavin@dsr-corporation.com>
skhoroshavin
approved these changes
Sep 19, 2019
|
This pull request introduces 4 alerts when merging 2685376 into 0032d6b - view on LGTM.com new alerts:
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Signed-off-by: toktar renata.toktar@dsr-corporation.com