INDY-2178 Integrate ViewChange messages requesting to ViewChangeService #1342
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: toktar <renata.toktar@dsr-corporation.com>
…nto task-2178-view-change-requestor
Toktar
requested review from
lampkin-diet,
ashcherbakov and
skhoroshavin
as code owners
Toktar
changed the title
Signed-off-by: toktar <renata.toktar@dsr-corporation.com>
|
This pull request introduces 1 alert when merging 6fa8af2 into c04bc34 - view on LGTM.com new alerts:
|
Toktar
changed the title
Signed-off-by: toktar <renata.toktar@dsr-corporation.com>
Signed-off-by: toktar <renata.toktar@dsr-corporation.com>
|
This pull request introduces 1 alert when merging 4648b37 into c04bc34 - view on LGTM.com new alerts:
|
Signed-off-by: toktar <renata.toktar@dsr-corporation.com>
|
This pull request introduces 1 alert when merging 8ca0da5 into c04bc34 - view on LGTM.com new alerts:
|
plenum/common/messages/fields.py
Outdated
|
|
||
| def _specific_validation(self, val): | ||
| if len(val) != 4: | ||
| return 'should have size of 4' | ||
|
|
||
| bid = BatchID(*val) | ||
| bid = BatchID(**val) if isinstance(val, dict) else BatchID(*val) |
There was a problem hiding this comment.
- I don't think we need to support both dict and tuple when serialized
- This can throw, for example if we receive dict with some keys not in BatchID field list
| @@ -321,15 +321,21 @@ def __init__(self, *args, **kwargs): | |||
| super().__init__(*args, **kwargs) | |||
| if isinstance(self.checkpoint, dict): | |||
| self.checkpoint = Checkpoint(**self.checkpoint) | |||
| self.batches = [BatchID(*bid) for bid in self.batches] | |||
| if not self.batches or not isinstance(self.batches[0], dict): | |||
There was a problem hiding this comment.
Adding comment explaining this would be very nice
Signed-off-by: toktar <renata.toktar@dsr-corporation.com>
|
This pull request introduces 1 alert when merging c10f080 into a12eaad - view on LGTM.com new alerts:
|
skhoroshavin
approved these changes
Sep 23, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.