Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

INDY-2140: Cleanup old view change logic #1360

Merged
merged 2 commits into from
Oct 4, 2019

Conversation

skhoroshavin
Copy link
Member

No description provided.

Sergey Khoroshavin added 2 commits October 3, 2019 18:11
Signed-off-by: Sergey Khoroshavin <sergey.khoroshavin@dsr-corporation.com>
Signed-off-by: Sergey Khoroshavin <sergey.khoroshavin@dsr-corporation.com>
@lgtm-com
Copy link

lgtm-com bot commented Oct 3, 2019

This pull request introduces 8 alerts and fixes 494 when merging 4572afa into 3a603e2 - view on LGTM.com

new alerts:

  • 2 for Signature mismatch in overriding method
  • 2 for Module is imported with 'import' and 'import from'
  • 1 for Should use a 'with' statement
  • 1 for Missing call to __init__ during object initialization
  • 1 for Module-level cyclic import
  • 1 for Mismatch between signature and use of an overridden method

fixed alerts:

  • 337 for Property in old-style class
  • 100 for 'super' in old style class
  • 14 for Wrong name for an argument in a call
  • 10 for Inconsistent equality and inequality
  • 9 for Inconsistent equality and hashing
  • 9 for Result of integer division may be truncated
  • 8 for Module imports itself
  • 2 for Missing call to __init__ during object initialization
  • 2 for Module-level cyclic import
  • 1 for __iter__ method returns a non-iterator
  • 1 for Unused argument in a formatting call
  • 1 for List comprehension variable used in enclosing scope

@skhoroshavin
Copy link
Member Author

(CI) test this please

@skhoroshavin skhoroshavin merged commit d8ba079 into hyperledger:master Oct 4, 2019
@skhoroshavin skhoroshavin deleted the indy-2140 branch October 4, 2019 11:06
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants