INDY-2140: Sync finishing view change on backups and master + more cleanups #1362
Conversation
Signed-off-by: Sergey Khoroshavin <sergey.khoroshavin@dsr-corporation.com>
skhoroshavin
requested review from
lampkin-diet,
ashcherbakov and
Toktar
as code owners
skhoroshavin
changed the title
Signed-off-by: Sergey Khoroshavin <sergey.khoroshavin@dsr-corporation.com>
|
This pull request introduces 1 alert when merging 837336b into d8ba079 - view on LGTM.com new alerts:
|
Signed-off-by: Sergey Khoroshavin <sergey.khoroshavin@dsr-corporation.com>
|
This pull request introduces 1 alert when merging 89b41dd into d8ba079 - view on LGTM.com new alerts:
|
Signed-off-by: Sergey Khoroshavin <sergey.khoroshavin@dsr-corporation.com>
skhoroshavin
changed the title
Signed-off-by: Sergey Khoroshavin <sergey.khoroshavin@dsr-corporation.com>
|
This pull request fixes 6 alerts when merging 72db03c into d8ba079 - view on LGTM.com fixed alerts:
|
Signed-off-by: Sergey Khoroshavin <sergey.khoroshavin@dsr-corporation.com>
|
This pull request fixes 6 alerts when merging 3a1ccfa into bb9b086 - view on LGTM.com fixed alerts:
|
|
This pull request fixes 6 alerts when merging 91c3904 into 2c081b8 - view on LGTM.com fixed alerts:
|
Signed-off-by: Sergey Khoroshavin <sergey.khoroshavin@dsr-corporation.com>
|
This pull request fixes 6 alerts when merging a100bfd into 417d195 - view on LGTM.com fixed alerts:
|
Signed-off-by: Sergey Khoroshavin <sergey.khoroshavin@dsr-corporation.com>
|
This pull request fixes 6 alerts when merging f3ad1ea into 417d195 - view on LGTM.com fixed alerts:
|
Signed-off-by: Sergey Khoroshavin <sergey.khoroshavin@dsr-corporation.com>
|
This pull request fixes 7 alerts when merging b3a7a46 into 5493909 - view on LGTM.com fixed alerts:
|
|
(CI) test this please |
| @@ -2334,6 +2333,11 @@ def _process_pre_prepare_from_old_view(self, pp): | |||
|
|
|||
| return PROCESS, None | |||
|
|
|||
| def _reordered_in_new_view(self): | |||
| self._stasher.process_all_stashed(STASH_VIEW_3PC) | |||
| # TODO: Why do we call it "reordered" despite that we only _started_ reordering old batches? | |||
There was a problem hiding this comment.
Agree with the comment. I was under the impressions that we send it after we ordered (re-ordered) till prepared certificate, but it looks like we send it when just going to do the re-ordering.
There was a problem hiding this comment.
Yet I think that it is right place to call process_all_stashed, so probably it is just a matter of renaming. However I'm not so sure about monitor reset...
Signed-off-by: Sergey Khoroshavin <sergey.khoroshavin@dsr-corporation.com>
Signed-off-by: Sergey Khoroshavin <sergey.khoroshavin@dsr-corporation.com>
|
This pull request fixes 6 alerts when merging 2d6e054 into 5493909 - view on LGTM.com fixed alerts:
|
Signed-off-by: Sergey Khoroshavin <sergey.khoroshavin@dsr-corporation.com>
Signed-off-by: Sergey Khoroshavin <sergey.khoroshavin@dsr-corporation.com>
|
This pull request introduces 1 alert and fixes 6 when merging 5b35c4c into f4d6444 - view on LGTM.com new alerts:
fixed alerts:
|
Signed-off-by: Sergey Khoroshavin sergey.khoroshavin@dsr-corporation.com